Just wanted to confirm: (:require ["react-virtualized" :refer (Column Table)]) does NOT do tree shaking.

at least in :shadow mode

correct. split it into two requires.

so this is recommended (as in docs): (:require ["react-virtualized/dist/commonjs/AutoSizer" :default virtual-auto-sizer] ["react-virtualized/dist/commonjs/List" :default virtual-list]))

cool thanks

es or commonjs yes

I would recommend the es versions

? not sure if I understand

in the path it says commonjs. "react-virtualized/dist/commonjs/AutoSizer"

oh ok! haha

they do actually ship 2 versions which are bundled slightly differently

its a bit more efficient to use the es version "react-virtualized/dist/es/AutoSizer"

Is there a way to do feature flags without env vars?

no idea what you mean by that?

sorry I'll explain later

hey folks - does anyone have any externs handy for using express?

advanced optimisations are clobbering the lib's vars

use https://shadow-cljs.github.io/docs/UsersGuide.html#infer-externs

we already had :infer-externs :auto turned on and changing to simple (instead of advanced) solved the issue

though there could be another interrelated setting that bungled stuff

and you didn't get any warnings?

Hmm just speaking with my team-member it was specifically to do with some middleware and an exception handling callback

hmm? do you mean that the JS is accessing a property from CLJS that is getting renamed?

I feel I can see how that might be harder to infer - let me dive a bit deeper.

I'll see if I can put together a minimal replication

infer works for anything where you access a JS property from CLJS

not the other way around

ok that's interesting, I can see a line which looks suspect so I'll take a look at that specific bit

I receive a couple of warnings with transit-cljs, not a big deal, just wanted to report them:

------ WARNING #2 -------------------------------------------------------------- 
File: com/cognitect/transit/impl/writer.js:256:8
variable isObject is undeclared
--------------------------------------------------------------------------------
------ WARNING #3 --------------------------------------------------------------
 File: com/cognitect/transit/types.js:384:70
 variable Buffer is undeclared

also, is there a way to disable warning colors?

yeah. known issue. can't do anything about that

kk cool

colors off isn't exposed so I guess its not possible

is anything we can do about that > contributing it? it is quite annoying in CI 😄

actually...let me explore the code 😉

there is a shadow.build.warnings/*color* binding

ah nice

but yeah...will get back to you, thanks for now 😄

If I run shadow-cljs release app, the first time I will get an error compiling my code but subsequent runs the error is not printed. This behavior does not make sense to me.

what is the error?

------ ERROR -------------------------------------------------------------------
 File: /home/kenny/compute_software/ui-frontend/src/compute/ui_frontend/core.cljs:41:3
--------------------------------------------------------------------------------
  38 |   []
  39 |   (s/check-asserts true)
  40 |   (set! s/*explain-out* expound/printer)
  41 |   (st/instrument)
---------^----------------------------------------------------------------------
Unable to resolve var: def-command-spec in this context at line 41 compute/ui_frontend/core.cljs
--------------------------------------------------------------------------------

Updating to 2.5.0 to see if the problem still occurs.

pretty sure that st/instrument is never going to work in :advanced?

def-command-spec is a macro BTW.

Updated to 2.5.0 and still have the issue.

I'm not sure why that code is even getting compiled. It is located in this function:

(defn init-dev-tools
  []
  (s/check-asserts true)
  (set! s/*explain-out* expound/printer)
  (st/instrument)
  nil)

(when ^boolean goog.DEBUG
  (init-dev-tools))

I would recommend putting stuff like this into an extra ns and use :preloads

the ns that is in will stilll have the st and expound requires otherwise

but as far as the problem goes I'm not actually sure

instrument is a funky macro

Ok, I can do that. I would've thought that because that function call never occurs DCE would remove expound and st.

yeah don't rely on DCE too much. there are lots of things that it can't remove. especially things the st ns does

I'll try moving that stuff to a preload. FWIW, def-command-spec is a Spec'ed macro.

I'm not entirely sure why it doesn't fail the second time though

oh wait I actually do

Oh, and the problem only occurs when I call def-command-spec in the same ns it is defined in.

st/instrument is a side effecting macro

but the ns is still cached so the side effects won't happen when using the cached code

yeah don't ever call that in a release build. even when its supposed to be DCE'd

Are preloads called every time code reloads?

no but you can force it via (ns ^:dev/always your.preloads)

just make sure that your "preload" depends on your main entries

otherwise the st/instrument code won't actually instrument anything since your code isn't loaded yet

Rightttt

Will that force everything to be reloaded every time?

hmm? no only that ns

Even though it depends on my main entries?

that doesn't matter since they don't depend on the preload

gotta go, bbl

What's the way to resolve classpath conflicts in the most recent 2.5.0 version of shadow cljs? I have tried the re-frame conduit example. The compilation errors out because apparently an old version of re frame gets loaded. It's surprising because the dependencies vectors in shadow-cljs.edn explicitly lists a more recent version of re-frame. I have tried using exclusions but couldn't get it to work either.

shadow-cljs deps-tree is new

interesting error

looking into it

hehe nice

reagent is an explicit dependency but re-frame depends on reagent/reagent. guess tools.deps doesn't de-dupe those

I see

hmm or its just me using it wrong

can't replicate with clj alone

@davidst should be fixed in 2.5.1

@thheller great thank you

Suppose I want to use some javascript library only while in development. How would one go about setting this up?

{:devtools {:preloads ...?

But then do I have to require this code in a namespace that is not reachable from the build's :entries?

or is :preloads only for clojure dependencies (not clojurescript or javascript)?

I suppose what I want to do is just have a clojurescript file under at dev/usr.cljs.

I'll see if I can use this code by eval'ing in cider-emacs I suppose this code that get required in dev/user.cljs will not get included in any build output provided it isn't called via code in the :entries namespaces.

yes :preloads is for dev-only code. the ns included via :preloads must however not the required by anything else

otherwise you might just leave it out of :preloads entirely since it will be included anyways

this is an option if you want to just remove one require https://shadow-cljs.github.io/docs/UsersGuide.html#_conditional_reading

aaaarg so excited about the new runtime dep feature........

shadow.user> (shadow/reload-deps! '{specs {:local/root "../spec-cljs"}})
:shadow.cljs.devtools.api/standalone-only
shadow.user> 

😄 😄 🙂

so nice that we have it in there though