Clojurians Log v2
polylith 2024-08-06
TIL. One cannot simply create a profile with / in its name. Why so? tools.deps support any legal Clojure keyword as an alias, e.g. :+db/postgres. Should the poly tool support them as well?
I need to think about this a bit before I dare answer. Allowing / can affect the experience of working with the poly-tool from a shell. I will report back when I have looked into this more closely. I'm on holiday now and have some booked, but I'll get back to you.
Yeah, I work within the shell myself, so, probably, this is the main suspect. I understand how such things (`:` and / in names) can be off-road when it comes to, say, naming components, since they end up in file names. But this case is different, imo, since it only deals with internals of a regular EDN file.
No rush. I just decided to ask before filing a GH issue. Have a nice holiday!
I have now verified that it seems to work fine to have / in profile names. I'm on holiday, but will push this as soon as possible @mstoyukhin!
Yay! Much appreciated, Joakim. ❤️ There’s no rush, btw — it’s an annoying thing, but the workaround is straightforward (temporarily renaming profiles).
Since poly uses Edamame to parse source code, right?
The latest https://cljdoc.org/d/polylith/clj-poly/0.3.21-SNAPSHOT/doc/readme #4 now uses the latest version of Edamame @seancorfield.
Thanks. I'll update our deps.edn at work in a few minutes.
Is this an answer to my question in the previous post? Sorry, I failed to follow here.
It was a heads-up to the Polylith team that they need to update their Edamame dependency (and hopefully release a new snapshot with that). For those of us that are already using Clojure 1.12 in production.