polylith

Mark Sto 2024-08-06T13:59:04.015559Z

TIL. One cannot simply create a profile with / in its name. Why so? tools.deps support any legal Clojure keyword as an alias, e.g. :+db/postgres. Should the poly tool support them as well?

πŸ‘€ 1
tengstrand 2024-08-08T09:00:15.660899Z

I need to think about this a bit before I dare answer. Allowing / can affect the experience of working with the poly-tool from a shell. I will report back when I have looked into this more closely. I'm on holiday now and have some booked, but I'll get back to you.

❀️ 1
Mark Sto 2024-08-08T09:32:18.656039Z

Yeah, I work within the shell myself, so, probably, this is the main suspect. I understand how such things (`:` and / in names) can be off-road when it comes to, say, naming components, since they end up in file names. But this case is different, imo, since it only deals with internals of a regular EDN file.

Mark Sto 2024-08-08T09:33:04.440109Z

No rush. I just decided to ask before filing a GH issue. Have a nice holiday!

tengstrand 2024-08-15T06:10:12.972889Z

I have now verified that it seems to work fine to have / in profile names. I'm on holiday, but will push this as soon as possible @mstoyukhin!

πŸ”₯ 1
Mark Sto 2024-08-15T08:44:26.967219Z

Yay! Much appreciated, Joakim. ❀️ There’s no rush, btw β€” it’s an annoying thing, but the workaround is straightforward (temporarily renaming profiles).

πŸ‘ 1
seancorfield 2024-08-06T17:38:45.915359Z

Since poly uses Edamame to parse source code, right?

tengstrand 2024-08-08T11:48:32.449729Z

The latest https://cljdoc.org/d/polylith/clj-poly/0.3.21-SNAPSHOT/doc/readme #4 now uses the latest version of Edamame @seancorfield.

seancorfield 2024-08-08T15:17:00.506509Z

Thanks. I'll update our deps.edn at work in a few minutes.

πŸ‘ 1
Mark Sto 2024-08-07T17:37:00.651089Z

Is this an answer to my question in the previous post? Sorry, I failed to follow here.

seancorfield 2024-08-07T17:53:50.877989Z

It was a heads-up to the Polylith team that they need to update their Edamame dependency (and hopefully release a new snapshot with that). For those of us that are already using Clojure 1.12 in production.

tengstrand 2024-08-07T18:00:13.573489Z

I will try to release a snapshot tomorrow.

πŸ‘πŸ» 1