Clojurians Log v2
Clojure programming
Channels
Apps
honeysql 2024-11-22
plooney 2024-11-22T17:07:48.360309Z
Anyone have some guidance on how to extend honey-sql operators with respect to NOT BETWEEN?
Currently I’ve done:
{:select [:*]
:from [:orders]
:where [:not
[[:between :amount 100 500]]]}SELECT *
FROM orders
WHERE NOT (amount BETWEEN 100 AND 500)SELECT *
FROM orders
WHERE amount NOT BETWEEN 100 AND 500
p-himik 2024-11-22T17:12:17.438329Z
I would most definitely just use [:not [:between ...]]. So, you don't need those extra [...].
But you can register custom clauses with honey.sql/register-clause!.
✅ 1
plooney 2024-11-22T17:18:39.588309Z
I ended up doing:
(honey/register-fn!
:not-between
(fn [_ [x a b]]
(let [[sql-x & params-x] (honey/format-expr x {:nested true})
[sql-a & params-a] (honey/format-expr a {:nested true})
[sql-b & params-b] (honey/format-expr b {:nested true})]
(-> [(str sql-x " NOT BETWEEN " sql-a " AND " sql-b)]
(into params-x)
(into params-a)
(into params-b)))))plooney 2024-11-22T17:21:27.159949Z
So it’s now:
(-> {:select [:*], :from [:orders], :where [:not-between :amount 100 500]}
(honey/format {:inline true}))
;;==> ["SELECT * FROM orders WHERE amount NOT BETWEEN 100 AND 500"]p-himik 2024-11-22T17:24:48.721209Z
10 lines of code to replace [:not [:between ...]] with [:not-between ...]. :)
plooney 2024-11-22T17:41:40.327829Z
I know I’m being a little much 🙂
seancorfield 2024-11-22T18:23:12.840439Z
Create a GH issue and I'll add it to core. NOT BETWEEN is a reasonable bit of syntax -- I just didn't know about it when I implemented BETWEEN 🙂