funcool

Aleed 2022-04-21T16:29:06.521699Z

the latest yetti on github seems to not have the appropriate request map for ring middleware? when i pin the version that penpot uses, it works correctly. i can log request object and see :request-method in fields when i use the version recommended in readme, i see #yetti.request.ExchangeWrapper{:method :get} but no request-method which is what many ring plugins seem to rely on

Aleed 2022-04-21T16:30:14.370819Z

i’m not too familiar with ring yet so stumbling my way through this šŸ˜† going to use the version that works for now, but i’d like to know if this is a regression or an intentional change

niwinz 2022-04-22T07:17:48.369999Z

hello @alidcastano, yetti uses ring-2.0 interfaces, but does not depend on ring because 2.0 is not properly released.

niwinz 2022-04-22T07:17:59.499979Z

i mean, it is ready to depend on ring 2.0 when it is released

niwinz 2022-04-22T07:18:23.015189Z

until now, we don't have "public" releases, and maybe I have forgoten update the readme

niwinz 2022-04-22T07:18:32.354759Z

you should use the version that penpot uses

niwinz 2022-04-22T09:40:45.635009Z

yetti is not intended to be used without any adaptation with ring v1 based dependencies, because it will not work

Aleed 2022-04-22T12:42:27.328689Z

I read that part of the readme, so I figured that was the reason. Though haven't looked at api changes between v1 n v2. did the version that pen pot uses support v1?

niwinz 2022-04-22T12:42:52.520419Z

penpot uses the v9.1

niwinz 2022-04-22T12:43:53.713379Z

but yes, the main branch uses the v4.0 that was partially compatible with ring

niwinz 2022-04-22T12:44:11.200899Z

but on staging and develop for long time the v9.1 is used

niwinz 2022-04-22T12:45:25.493059Z

Unless you need something special and you know what your doing, I strongly recommend use https://github.com/sunng87/ring-jetty9-adapter

šŸ‘ 1
Aleed 2022-04-22T13:19:08.828159Z

Cool I'll check out that lib too, thanks for input