Fork me on GitHub
#funcool
<
2022-04-21
>
Aleed16:04:06

the latest yetti on github seems to not have the appropriate request map for ring middleware? when i pin the version that penpot uses, it works correctly. i can log request object and see :request-method in fields when i use the version recommended in readme, i see #yetti.request.ExchangeWrapper{:method :get} but no request-method which is what many ring plugins seem to rely on

Aleed16:04:14

i’m not too familiar with ring yet so stumbling my way through this 😆 going to use the version that works for now, but i’d like to know if this is a regression or an intentional change

niwinz07:04:48

hello @UPH6EL9DH, yetti uses ring-2.0 interfaces, but does not depend on ring because 2.0 is not properly released.

niwinz07:04:59

i mean, it is ready to depend on ring 2.0 when it is released

niwinz07:04:23

until now, we don't have "public" releases, and maybe I have forgoten update the readme

niwinz07:04:32

you should use the version that penpot uses

niwinz09:04:45

yetti is not intended to be used without any adaptation with ring v1 based dependencies, because it will not work

Aleed12:04:27

I read that part of the readme, so I figured that was the reason. Though haven't looked at api changes between v1 n v2. did the version that pen pot uses support v1?

niwinz12:04:52

penpot uses the v9.1

niwinz12:04:53

but yes, the main branch uses the v4.0 that was partially compatible with ring

niwinz12:04:11

but on staging and develop for long time the v9.1 is used

niwinz12:04:25

Unless you need something special and you know what your doing, I strongly recommend use https://github.com/sunng87/ring-jetty9-adapter

👍 1
Aleed13:04:08

Cool I'll check out that lib too, thanks for input