Clojurians Log v2
Clojure programming
Channels
Apps
fulcro 2025-06-21
sheluchin 2025-06-21T17:57:55.654679Z
(ns fiddles.targeting
(:require
[com.fulcrologic.fulcro.algorithms.data-targeting :as targeting]))
(comment
;; this one works
(targeting/process-target
{:a {:b {:c 1}}}
[:a :b :c]
[:new-loc/id 999]
true) ; {:a {:b {}}, :new-loc/id {999 1}}
;; works again
(targeting/process-target
{:a {:b {["x" "y"] 1}}}
[:a :b ["x" "y"]]
[:new-loc/id 999]
true) ; {:a {:b {}}, :new-loc/id {999 1}}
(targeting/process-target
{:composite-key {["x" "y"] 1}}
[:composite-key ["x" "y"]]
[:new-loc/id 999]
true)
; {:composite-key {["x" "y"] 1},
; :new-loc/id {999 [:composite-key ["x" "y"]]}}sheluchin 2025-06-25T13:20:23.332129Z
Thanks. Makes sense. Looks like source-path interprets any two-element vector/path as an ident and doesn't check if it's a keyword, and in such cases the remove-source? argument isn't used at all. Do you think it would be helpful to clarify this in the docstring? I can patch it if you think so.
tony.kay 2025-06-25T14:56:50.585099Z
This function is really meant for internal use by the targeting system. I’ve never called them directly in any application I’ve built in the years since I created it. You can send a patch for the docstring if you want
sheluchin 2025-06-25T14:57:43.856719Z
Fair enough 🙂 thanks for clarifying.
tony.kay 2025-06-23T16:20:32.266459Z
Not a bug. Source path can be an ident. And you’ve given it something that looks like an ident. The docstring clearly says: `
If the source path is an ident, then that is what is placed
in app state.tony.kay 2025-06-23T16:20:50.438159Z
an ident is defined as a vector with a keyword as the first element. The ID is allowed to be anything
tony.kay 2025-06-23T16:21:02.654119Z
this is to preserve normalization
tony.kay 2025-06-23T16:21:25.524749Z
the fact that your target path was an ident is just not a supported case that the design intends