Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2021-06-19

Channels

#fulcro
<
2021-06-19
>
nivekuil20:06:48

3.5 seems to have changed something with the ordering of renders/transactions, not sure if it's intended. the effect I'm seeing is clerk is not restoring to the same scroll position as before under some circumstances (it needs the transaction containing clerk/after-render! to run after all renders). pretty subtle to try to repro unfortunately but I'll take a deeper look if it's a bug

tony.kay20:06:51

See note on release: after-render was moved. I left a deprecated var in the old place, but it isn't used.

tony.kay20:06:09

I should have probably just deleted it

tony.kay20:06:31

and I have no idea what "clerk" is

nivekuil20:06:08

clerk is https://github.com/PEZ/clerk. I'm not using the after-render dyn var, just the :after-render? key in the mutation opts, was that also affected?

tony.kay16:06:53

I do not see any reason why that would have changed.

nivekuil05:06:17

I think this was a caching issue. I can repro it if I pull my local fulcro repo from 3.4->3.5 and let shadow recompile but not with a clean build