figwheel-main

bhauman 2022-05-16T13:10:06.186559Z

@augustl so you are running figwheel with 1.11.51 without a problem?

bhauman 2022-05-16T13:10:46.164429Z

It seems that figwheel-main is having a problem with 1.11.51. Is anyone else seeing this?

danieroux 2022-05-16T13:53:29.340079Z

Yes. Haven't had time to isolate what it is.

2022-05-16T13:22:13.420519Z

@bhauman I actually only tested minified compiling, I didn't run it in dev mode yet

bhauman 2022-05-16T13:28:51.289499Z

if you do I think you will notice a missing clojure.data.json dep. which you can simply add to your deps. Then you might see a problem where cljs is missing a vendor/bridge file.

bhauman 2022-05-16T13:29:17.571799Z

I just need to confirm that others are experiencing this.

bhauman 2022-05-16T13:36:45.184449Z

@augustl ^ (I forgot how to use slack …)

😁 1
2022-05-16T13:43:03.963889Z

yeah, I got that error, and in complete braindead mode without any research or thinking I just added [org.clojure/data.json "2.4.0"] as a dependency. Everything seems to work fine, just started it up in "dev mode" as well 🙂

bhauman 2022-05-16T15:30:14.991599Z

@augustl are you starting a repl in dev mode? because that’s when the error occurs.

2022-05-16T16:56:35.227509Z

yeah, it's in dev mode

danieroux 2022-05-16T13:55:00.673249Z

vendor/bridge is in the stacktrace, and my initial (few minute) investigation had it happening in piggyback.

bhauman 2022-05-16T15:26:54.244399Z

Thanks for looking. Yeah its not in piggieback. It’s in Clojurescript when it starts a repl. It’s trying to dynamically load a file vendor/bridge.clj from the classpath and can’t find it.

dnolen 2022-05-16T15:52:11.674139Z

@bhauman is this specific to Piggieback though (since I didn't see this w/ plain usage), I see that Piggieback uses nREPL interruptible eval and there might be classloader tricks interfering? maybe way off base, but hard to think of how this could fail otherwise

bhauman 2022-05-16T15:52:45.868769Z

@dnolen Nope unfortunately not piggieback because I’m not using it

bhauman 2022-05-16T15:53:03.603829Z

I’m using plain jain clj with figwheel in a minimal project

bhauman 2022-05-16T15:53:16.196279Z

I also dissabled all classpath munging

dnolen 2022-05-16T15:53:25.344649Z

@bhauman you could try changing to (require 'cljs.vendor.bridge) in ClojureScript

dnolen 2022-05-16T15:53:34.722339Z

then ./script/build from ClojureScript repo

dnolen 2022-05-16T15:53:44.235919Z

and then note the artifact name

dnolen 2022-05-16T15:53:53.115949Z

if that works then can switch to that

bhauman 2022-05-16T15:53:54.527239Z

I changed it but the change isn’t taking with script build?

bhauman 2022-05-16T15:54:07.414599Z

@dnolen ^

dnolen 2022-05-16T15:54:31.283429Z

what does that mean? you just end up seeing the same problem?

bhauman 2022-05-16T15:55:15.246309Z

No I mean I’m using the Clojurescript build process and its not picking pu my changes in repl.cljc

bhauman 2022-05-16T15:55:26.183139Z

do I need to make a commit?

dnolen 2022-05-16T15:55:37.791359Z

like you look inside the JAR and it's not there?

bhauman 2022-05-16T15:55:58.769939Z

It’s inside the jar.

dnolen 2022-05-16T15:56:20.217569Z

make sure you blow away target, you should not have to do that but just in case

bhauman 2022-05-16T15:56:26.347089Z

OK

dnolen 2022-05-16T15:56:26.675269Z

and try again

bhauman 2022-05-16T15:57:07.587429Z

I added some stuff to print the classpath and see what the classloader is

bhauman 2022-05-16T16:11:36.975349Z

@dnolen as suspected the (require 'cljs.vendor.build) fixes it, I double and triple checked it.

dnolen 2022-05-16T16:13:16.167289Z

@bhauman k, fixing and releasing now

bhauman 2022-05-16T16:13:23.617469Z

Thank you!

dnolen 2022-05-16T16:18:00.520849Z

https://github.com/clojure/clojurescript/pull/179, waiting for tests to pass

🎉 3
bhauman 2022-05-16T16:19:34.569919Z

Thanks man

dnolen 2022-05-16T16:25:16.467889Z

@bhauman btw, good to see you 'wheelin 🙂

👍 3
bhauman 2022-05-16T16:26:22.178289Z

@dnolen I’ve not completely disappeared 😉

🎉 6
bhauman 2022-05-16T16:27:15.044559Z

I still do and have always loved the the ’wheel

dnolen 2022-05-16T16:34:56.417309Z

building / releasing 1.11.54

👍 2
bhauman 2022-05-16T17:23:57.152509Z

just released figwheel-main ‘0.2.18’ that includes the clojure.data.json dep

4