Fork me on GitHub
#figwheel-main
<
2022-05-16
>
bhauman13:05:06

@augustl so you are running figwheel with 1.11.51 without a problem?

bhauman13:05:46

It seems that figwheel-main is having a problem with 1.11.51. Is anyone else seeing this?

danieroux13:05:29

Yes. Haven't had time to isolate what it is.

augustl13:05:13

@bhauman I actually only tested minified compiling, I didn't run it in dev mode yet

bhauman13:05:51

if you do I think you will notice a missing clojure.data.json dep. which you can simply add to your deps. Then you might see a problem where cljs is missing a vendor/bridge file.

bhauman13:05:17

I just need to confirm that others are experiencing this.

bhauman13:05:45

@augustl ^ (I forgot how to use slack …)

😁 1
augustl13:05:03

yeah, I got that error, and in complete braindead mode without any research or thinking I just added [org.clojure/data.json "2.4.0"] as a dependency. Everything seems to work fine, just started it up in "dev mode" as well 🙂

bhauman15:05:14

@augustl are you starting a repl in dev mode? because that’s when the error occurs.

augustl16:05:35

yeah, it's in dev mode

danieroux13:05:00

vendor/bridge is in the stacktrace, and my initial (few minute) investigation had it happening in piggyback.

bhauman15:05:54

Thanks for looking. Yeah its not in piggieback. It’s in Clojurescript when it starts a repl. It’s trying to dynamically load a file vendor/bridge.clj from the classpath and can’t find it.

dnolen15:05:11

@bhauman is this specific to Piggieback though (since I didn't see this w/ plain usage), I see that Piggieback uses nREPL interruptible eval and there might be classloader tricks interfering? maybe way off base, but hard to think of how this could fail otherwise

bhauman15:05:45

@dnolen Nope unfortunately not piggieback because I’m not using it

bhauman15:05:03

I’m using plain jain clj with figwheel in a minimal project

bhauman15:05:16

I also dissabled all classpath munging

dnolen15:05:25

@bhauman you could try changing to (require 'cljs.vendor.bridge) in ClojureScript

dnolen15:05:34

then ./script/build from ClojureScript repo

dnolen15:05:44

and then note the artifact name

dnolen15:05:53

if that works then can switch to that

bhauman15:05:54

I changed it but the change isn’t taking with script build?

dnolen15:05:31

what does that mean? you just end up seeing the same problem?

bhauman15:05:15

No I mean I’m using the Clojurescript build process and its not picking pu my changes in repl.cljc

bhauman15:05:26

do I need to make a commit?

dnolen15:05:37

like you look inside the JAR and it's not there?

bhauman15:05:58

It’s inside the jar.

dnolen15:05:20

make sure you blow away target, you should not have to do that but just in case

dnolen15:05:26

and try again

bhauman15:05:07

I added some stuff to print the classpath and see what the classloader is

bhauman16:05:36

@dnolen as suspected the (require 'cljs.vendor.build) fixes it, I double and triple checked it.

dnolen16:05:16

@bhauman k, fixing and releasing now

bhauman16:05:23

Thank you!

bhauman16:05:34

Thanks man

dnolen16:05:16

@bhauman btw, good to see you 'wheelin 🙂

👍 3
bhauman16:05:22

@dnolen I’ve not completely disappeared 😉

🎉 6
bhauman16:05:15

I still do and have always loved the the ’wheel

dnolen16:05:56

building / releasing 1.11.54

👍 2
bhauman17:05:57

just released figwheel-main ‘0.2.18’ that includes the clojure.data.json dep

figwheel 4