Clojurians Log v2
Clojure programming
Channels
Apps
code-reviews 2024-01-16
Nundrum 2024-01-16T22:25:22.642289Z
Less of a code review request and more of a "did I do this right?" I just put a library on clojars and wanted to know if I made a mess of it. Any input is appreciated. https://clojars.org/net.nundrum/cljs-polys-etc/versions/0.0.1
seancorfield 2024-01-16T23:22:48.960219Z
It all looks good on Clojars and links to the right commit on GitHub.
You have a typo in your :deps line in the README: net.nundrum/clls-polys-etc (should be cljs-polys-etc)
seancorfield 2024-01-16T23:23:37.928799Z
I would expect to see a deps.edn file in the repo -- and maybe build.clj or something else?
seancorfield 2024-01-16T23:26:16.252879Z
Ah, you built it with Leiningen according to the pom -- so maybe I should expect to see project.clj in GitHub 🙂
Nundrum 2024-01-16T23:45:39.310239Z
Good catch! I'll fix that right up.
Nundrum 2024-01-16T23:46:39.095599Z
Yeah, I started out trying to deploy with deps.edn, tools.deps, etc, but finally gave up and tried lein. That's why I hadn't committed it yet.
👍🏻 1
Nundrum 2024-01-16T23:46:58.307119Z
Thanks for taking a look. I really appreciate it. gratitude-thank-you