code-reviews

2021-08-09T18:08:50.001500Z

Hey folks, I just finished a little project of mine

2021-08-09T18:08:52.001600Z

https://github.com/dev-hartmann/gitdo

2021-08-09T18:09:32.002800Z

Would love to get feedback on the code 🙏🏽

emccue 2021-08-09T20:10:42.003900Z

only piece of feedback i have rn is that if you have a function with a bunch of arguments, using keyword arugments can be helpful

2021-08-09T21:42:39.004500Z

it's odd that get-items has one if branch that returns a lazy-seq of strings, and another that returns a string

2021-08-09T21:43:24.005600Z

and +1 about argument count, I wouldn't even remember what the arguments mean positionally for a clojure.core function with five args, I definitely won't waste my time learning it for some random project