Fork me on GitHub
#code-reviews
<
2021-08-09
>
dev-hartmann18:08:50

Hey folks, I just finished a little project of mine

dev-hartmann18:08:32

Would love to get feedback on the code 🙏:skin-tone-4:

emccue20:08:42

only piece of feedback i have rn is that if you have a function with a bunch of arguments, using keyword arugments can be helpful

noisesmith21:08:39

it's odd that get-items has one if branch that returns a lazy-seq of strings, and another that returns a string

noisesmith21:08:24

and +1 about argument count, I wouldn't even remember what the arguments mean positionally for a clojure.core function with five args, I definitely won't waste my time learning it for some random project