Clojurians Log v2
Clojure programming
Channels
Apps
code-reviews 2020-07-13
I wrote a quick wrap-cors middleware:
(defn wrap-cors [handler]
(fn [request]
(let [res (handler request)]
(if-not res
res
(-> res
(assoc-in [:headers "Access-Control-Allow-Origin"] "*")
(assoc-in [:headers "Access-Control-Allow-Headers"] "*"))))))if-not -- if you think there's a more concise way I can express this would love thoughts : )
dharrigan 2020-07-13T19:12:10.161600Z
would this work?
dharrigan 2020-07-13T19:12:13.161800Z
(defn wrap-cors [handler]
(fn [request]
(some-> (handler request)
(assoc-in [:headers "Access-Control-Allow-Origin"] "*")
(assoc-in [:headers "Access-Control-Allow-Headers"] "*"))))
also, the double assoc in could just be an update-in (update-in [:headers] assoc "Access-Control-Allow-Origin" "**" "Access-Control-Allow-Headers" "**")
dharrigan 2020-07-13T19:17:56.163400Z
noice!
dharrigan 2020-07-13T19:18:22.163700Z
I do love me some Clojure expressiveness 🙂
another way to replace (if-not x x ...) is (and x ...)
it has the same conditional branching and delayed evaluation as if
oof butiful. Thanks team!
seancorfield 2020-07-13T20:13:29.165400Z
FYI @stopachka There's an existing middleware library for that https://github.com/r0man/ring-cors which handles the preflight checking (which your code does not).
👍 2
seancorfield 2020-07-13T20:13:49.165900Z
(this library is what we use at work for production CORS checking)
❤️ 1
Bam updated, thanks Sean!