Github syntax highlight for clojure seems to have a lot of bugs that was already fixed in the calva clojure.tmLanguage.json, i suppose it due to https://github.com/github-linguist/linguist using the archived https://github.com/atom/language-clojure project. I just realised this because of a binding starting with a pipe char that seems to be highlighted as paren. Is there a way to point linguist to calva instead of atom?
Has someone created an issue on the linguist repo to suggest they switch to the more up-to-date language JSON file?
Ah, there's this (closed) issue about the archived atom grammars: https://github.com/github-linguist/linguist/issues/6251
I was checking that rn, it doesn't seems to be the case. I'm not sure if that is appropriate, but if so i can see this thought their process (seems a bit more involved)
i think it should be pretty safe to do right? the calva one is better maintained and a direct successor
Yeah, I'd say a PR against linguist, switching the Clojure stuff over to the Calva file would be appropriate, given that it would fix bugs in the GitHub highlighting...
The Calva file has some special treatment for the Calva repl window that isn’t relevant outside the Calva context. But that’s easy to clean away.
They are requiring the file to be placed at /grammars/ or /syntaxes/ , which i would say is a strange (and undocumented) expectation
Ah, so there's some Calva work needed to get to a place where we could try to persuade the linguist project to switch?