@thheller FYI considering you recently moved shadow-cljs to a newer version of the google-closure-library, I created a https://github.com/clojure/clojurescript/pull/200 to move clojurescript to match. We were nervous that they were on different versions. Hope that's okay.

@t.denley thanks but it’s odd that none of the tests ran

note that there was one issue with goog.requireType in that release https://github.com/thheller/shadow-cljs/issues/1097

it might not be an issue when loading code using the built-in debug loader though, could have just been the custom loader shadow-cljs uses

besides that no issues yet it seems. but probably wait till a few more people have upgraded.

@dnolen https://github.com/clojure/clojurescript/blob/6dac3165d4bc8f785741ea86aef946b11c9d7d0f/.github/workflows/test.yaml#LL2-L2C10. You might have noticed prs from local branches building fine. GHA is confusing, at least to me, in this area. In the past I've used configs like https://github.com/clj-commons/pomegranate/blob/be2482b31f1b94a9743d28372f5ebda9891cbb25/.github/workflows/tests.yml#L5-L8.

I'd say just add pull_request to it and be done with it.

Yeah, depends on what you want. If you go that route GHA will trigger the tests twice for commits to PRs. I'm currently trying to figure out how to get GHA to not do this. So far I've only found that it does not seem easy.

it will only execute the tests twice if you push to your own repo's PR

You'll see the the duplicate tests run if pushing to a PR from a local branch in the GHA PR UI. They'll still be run twice if the PR is from a fork (if GHA is enabled for that fork). Once in the forked repo, once in the repo, but you won't see the duplication in the GHA PR UI.

I think I'd prefer having tests run too much rather than too few, until you find a good solution to deduplicate ;)

Yeah, I'm working on it. It is... annoying. Oddly, this use case is not one GitHub Actions team seems to have designed for. Use case being: please trigger workflow when pushing anywhere but only trigger once when commit is part of a PR.

@dnolen I assume the test run issue is being dealt with and you don't want me to do anything to the pull request?