cljs-dev 2019-05-01 | Slack Archive

@lee right that should probably be updated - PR for that welcome!

https://github.com/clojure/clojurescript-site/pull/311

I am thinking that https://github.com/clojure/clojurescript/blob/master/script/test should clearly report failure and exit with non-zero when anything goes wrong. I got summary of “Tested with 6 out of 6 possible js targets” and an exit of 0 when I had a wonky WebKit config. Seems worthy of a JIRA issue, no? Shall I raise one?

dnolen20:05:07

@lee I don't think particular approach is desirable

dnolen20:05:15

the current thing tests what you have

dnolen20:05:31

I think a better approach would be to determine that no tests were run

dnolen20:05:54

or to print a error message when one particular test environment fails somehow

dnolen20:05:06

but to continue on

dnolen20:05:42

there's also the issue that sometimes we don't really care if something fails in a lower value environment

dnolen20:05:50

like Nashorn or Graal.js

dnolen20:05:25

it's interesting to know - but doesn't say anything meaningful like the tests passing under V8, FF, & JSC

lread20:05:42

Interesting. As a newbie I did not realize some envs were lower value with regards to tests.

lread20:05:46

lread20:05:55

Continuing with current behaviour but with a better summary and an non-zero exit on any failure is probably still desirable?

dnolen20:05:50

yeah that would be fine - we haven't really invested much in the test script because it's only really for folks submitting patches - if we had a CI thing going we might have cleaned it up a bit more - but currently we don't

lread20:05:14

yeah I noticed your travis script does its own thing

dnolen20:05:18

(well not an official one anyway)

dnolen20:05:20

yeap

dnolen20:05:38

bbiab

lread20:05:47

I think I’ll raise it (and fix it later). If it helps me, it will probably help others.

lread20:05:43

Same situtation for https://github.com/clojure/clojurescript/blob/master/script/test-simple