This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-05-01
Channels
- # aws (1)
- # beginners (237)
- # boot (2)
- # calva (6)
- # cider (16)
- # clara (10)
- # clj-kondo (1)
- # cljs-dev (24)
- # clojure (29)
- # clojure-brasil (2)
- # clojure-dev (20)
- # clojure-europe (1)
- # clojure-italy (56)
- # clojure-japan (1)
- # clojure-nl (16)
- # clojure-spec (12)
- # clojure-uk (12)
- # clojurescript (24)
- # clojureverse-ops (3)
- # core-async (3)
- # cursive (21)
- # datascript (5)
- # datomic (82)
- # devops (5)
- # duct (14)
- # emacs (2)
- # fulcro (2)
- # jobs (6)
- # juxt (7)
- # kaocha (6)
- # leiningen (19)
- # luminus (3)
- # nrepl (51)
- # off-topic (208)
- # other-languages (1)
- # re-frame (8)
- # reagent (9)
- # remote-jobs (6)
- # shadow-cljs (37)
- # spacemacs (6)
- # testing (12)
- # tools-deps (25)
I am thinking that https://github.com/clojure/clojurescript/blob/master/script/test should clearly report failure and exit with non-zero when anything goes wrong. I got summary of “Tested with 6 out of 6 possible js targets” and an exit of 0 when I had a wonky WebKit config. Seems worthy of a JIRA issue, no? Shall I raise one?
there's also the issue that sometimes we don't really care if something fails in a lower value environment
it's interesting to know - but doesn't say anything meaningful like the tests passing under V8, FF, & JSC
Interesting. As a newbie I did not realize some envs were lower value with regards to tests.
Continuing with current behaviour but with a better summary and an non-zero exit on any failure is probably still desirable?
yeah that would be fine - we haven't really invested much in the test script because it's only really for folks submitting patches - if we had a CI thing going we might have cleaned it up a bit more - but currently we don't
I think I’ll raise it (and fix it later). If it helps me, it will probably help others.
Same situtation for https://github.com/clojure/clojurescript/blob/master/script/test-simple
I assume https://clojurescript.org/community/running-tests#dont-forget is referencing https://github.com/clojure/clojurescript/tree/master/samples/repl … but this is documented as being out of date and points the reader to the quick start https://clojurescript.org/guides/quick-start. I’m guessing that this section should guide the reader to walking through the quick start as a verification step?