Bug discovered. Compile this src/foo.cljs:

(ns foo
  (:require [cljs.js :as cljs]))

(defn -main []
  (enable-console-print!)
  (println "hello"))

{:deps {org.clojure/clojure {:mvn/version "1.10.0-RC5"}
        org.clojure/clojurescript {:mvn/version "1.10.439"}
        }
 :aliases {:build-simple {:main-opts ["-m" "cljs.main" "-O" "simple" "-co" "{:pretty-print,false,:optimize-constants,true,:static-fns,true}" "-d" "out" "-c" "foo"]}}}

Circular dependency detected, cljs.core -> cljs.core

(the compile opts are the ones recommend for self-host: https://clojurescript.org/guides/self-hosting)

Will read+string (introduced in Clojure 1.10) be available in cljs?

it already exists in cljs.tools.reader

I don't really see the need given it's there - and it's mostly for tooling people

I didn’t notice it was in cljs.tools.reader. Will take a look. Thanks @dnolen

Following up on the earlier discussion about noting breaking changes https://clojurians.slack.com/archives/C07UQ678E/p1544746745174700

I'd personally appreciate leaning more on the side of noting possible breaking changes rather than not mentioning them at all. At times I've found upgrading to new versions of ClojureScript difficult because things have changed in a way that broke our code. For example https://dev.clojure.org/jira/browse/CLJS-2114

I already implied it's more or less a case by case basis

we could start noting them, though I might argue it will get ignored anyway

a better way is put your library into the OSS testing matrix

On thing I've actually found of value: Canary. It caught an inadvertent consequence of a change that broke Specter.

so you can find out about this stuff before the rude awakening

There is this entires class of "Hyrum" changes that could break things, that are great when Canary catches them.

bug? https://clojurians.slack.com/archives/C07UQ678E/p1544976186287600

The two examples in my mind: • Specter (the vec thing https://github.com/nathanmarz/specter/commit/e7abb2b5384b0b64d871fb347be7c34a15473eb2) • Secretary (the merge-with alignment with Clojure)

@borkdude it seems like a bug yes - but there's no information about how's that different from other usage of the self host ns

@dnolen I get this error with :optimize-constants true, not when set to false

@borkdude and that doesn't happen outside of self-host?

I’m not sure what you mean. This is a normal cljs project. I refer to the cljs.js namespace to get self-hosted eval, but I’m actually not using it at all in this example.

what I mean is, if you remove cljs.js, it works?

yes, then it works

I’ll try once more to confirm

confirmed

ok, make a minor self-host ticket, please point out the cause :optimize-constants true

👍

FWIW, I was trying out this setting because it was documented here: https://clojurescript.org/guides/self-hosting

https://dev.clojure.org/jira/browse/CLJS-3021