Clojurians
#cljs-dev
<
2017-09-30
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen09:09:20

@juhoteperi your patch for 2294 still does not apply cleanly for me

dnolen09:09:31

@bronsa applied, I bumped myself and fixed another issue

dnolen09:09:37

was a bit too busy with other work to get to a release the past 2 Fridays, I’m planning on cutting one on Monday - let me know if you want to see something in master

juhoteperi09:09:52

@dnolen You tried with the latest patch (-4)? it applies cleanly for me.

mfikes12:09:50

I’m assuming we will want js/Infinity to print as ##Inf (and similarly for js/-Infinity and js/NaN) for round tripping like Clojure 1.9 beta1 does. I’ll put together a ticket and see if this is feasible.

mfikes13:09:02

As you might expect, the code for this is easy to write, but it may be a challenge ensuring perf doesn’t regress. I’ll have to add some benchmarks to see what this does: https://github.com/mfikes/clojurescript/commit/ee17c353d8fe936d023419a786d07887f0f637ba

dnolen19:09:30

@mfikes thanks, in this case I don’t think the perf really matters much

dnolen19:09:42

or rather it’s less important than just getting this case in

dnolen19:09:39

@juhoteperi yeah pretty sure I tried 4 and it wasn’t working for me

dnolen19:09:15

it works, not sure what I was seeing before

anmonteiro21:09:38

^ Closure core team member

anmonteiro21:09:57

(this is from 2 days ago or something - Strangeloop 2017)