cljdoc

lread 2022-04-12T13:08:23.899429Z

That's great!

Cora (she/her) 2022-04-12T00:09:54.938939Z

or I guess you could use flexbox with flex-direction row and justify-content space-between and put view docs all the way to the right. maybe give it a white background color and rounded corners, like it's a button

Cora (she/her) 2022-04-12T00:09:59.283049Z

I have ideas

Cora (she/her) 2022-04-12T00:10:08.103289Z

I can always punch it up a little later if we need to

lread 2022-04-12T02:05:46.351289Z

Sounds good, thanks, I’ll release and am very happy if others see fit to refine it!

👍🏻 1
lread 2022-04-12T02:36:34.753499Z

And it is live! Love this merge to master to release business!

Cora (she/her) 2022-04-12T01:46:15.843709Z

I really am curious why there's this hidden form up in the top-bar https://github.com/corasaurus-hex/cljdoc/blob/27e69d236b7f8d2353585f282be81de50e7ce30b/src/cljdoc/render/layout.clj#L188-L192

lread 2022-04-12T02:09:05.762409Z

Hmm… I think that’s our secret rebuild link, yeah? You click it to attempt a rebuild of your docs. Are you wondering about it technically or about the UI design choice?

lread 2022-04-12T02:11:39.742789Z

I was thinking about this recently. We could make the build log page more accessible and then we could present a rebuild button on the build log page. And any specific wordy hints that seem to be targeted at authors of libs (rather than users of libs) could also move to the build log page.

Cora (she/her) 2022-04-12T02:18:04.679619Z

yeah, I was going to add search up there but it's really hard to style it there

Cora (she/her) 2022-04-12T02:18:14.130179Z

with the hidden thing taking up space

Cora (she/her) 2022-04-12T02:18:28.278549Z

time to put it back in the sidebar

Cora (she/her) 2022-04-12T02:18:38.572719Z

I'll just make the drop-down expand further

lread 2022-04-12T02:19:46.710319Z

It’s an interesting design choice… I think it is so… hidden… maybe because it doesn’t want to be smashed willy nilly by cljdoc users?

Cora (she/her) 2022-04-12T02:20:54.662599Z

yeah, that makes sense

phronmophobic 2022-04-12T02:21:48.542279Z

I've run into the issue where there's no obvious way to rebuild snapshot builds and found out about the rebuild button that way, https://github.com/cljdoc/cljdoc/issues/31#issuecomment-554298351

lread 2022-04-12T02:24:08.593959Z

Yeah, that rebuild button is usually only discovered after a support request.

lread 2022-04-12T02:25:46.803899Z

That issue you just linked to is an old sore spot for many. I was going to tackle it when I got around to handling source-based libs, but it could be handled separately.

phronmophobic 2022-04-12T02:27:43.583969Z

oh, I wasn't trying to bring up a sore point 😬

lread 2022-04-12T02:28:43.463879Z

Ha! Not a problem! simple_smile

😅 1
Cora (she/her) 2022-04-12T04:04:56.069469Z

lunr is returning matches that... aren't matches

lread 2022-04-12T04:24:43.843209Z

that’s annoying! lunr needs to lurn how to search more better

➕ 1
Cora (she/her) 2022-04-12T05:05:57.971499Z

it's shaping up pretty well otherwise

Cora (she/her) 2022-04-12T05:06:15.201409Z

I have some styling to do and a few more interactions to lock down

Cora (she/her) 2022-04-12T05:06:30.788999Z

but it's getting really close

Cora (she/her) 2022-04-12T05:07:32.675839Z

I also might move the downloading and indexing to a web worker and pass search data back and forth