Fork me on GitHub
#cljdoc
<
2022-04-12
>
Cora (she/her)00:04:54

or I guess you could use flexbox with flex-direction row and justify-content space-between and put view docs all the way to the right. maybe give it a white background color and rounded corners, like it's a button

Cora (she/her)00:04:08

I can always punch it up a little later if we need to

lread02:04:46

Sounds good, thanks, I’ll release and am very happy if others see fit to refine it!

1
lread02:04:34

And it is live! Love this merge to master to release business!

lread02:04:05

Hmm… I think that’s our secret rebuild link, yeah? You click it to attempt a rebuild of your docs. Are you wondering about it technically or about the UI design choice?

lread02:04:39

I was thinking about this recently. We could make the build log page more accessible and then we could present a rebuild button on the build log page. And any specific wordy hints that seem to be targeted at authors of libs (rather than users of libs) could also move to the build log page.

Cora (she/her)02:04:04

yeah, I was going to add search up there but it's really hard to style it there

Cora (she/her)02:04:14

with the hidden thing taking up space

Cora (she/her)02:04:28

time to put it back in the sidebar

Cora (she/her)02:04:38

I'll just make the drop-down expand further

lread02:04:46

It’s an interesting design choice… I think it is so… hidden… maybe because it doesn’t want to be smashed willy nilly by cljdoc users?

Cora (she/her)02:04:54

yeah, that makes sense

phronmophobic02:04:48

I've run into the issue where there's no obvious way to rebuild snapshot builds and found out about the rebuild button that way, https://github.com/cljdoc/cljdoc/issues/31#issuecomment-554298351

lread02:04:08

Yeah, that rebuild button is usually only discovered after a support request.

lread02:04:46

That issue you just linked to is an old sore spot for many. I was going to tackle it when I got around to handling source-based libs, but it could be handled separately.

phronmophobic02:04:43

oh, I wasn't trying to bring up a sore point 😬

lread02:04:43

Ha! Not a problem! simple_smile

😅 1
Cora (she/her)04:04:56

lunr is returning matches that... aren't matches

lread04:04:43

that’s annoying! lunr needs to lurn how to search more better

1
Cora (she/her)05:04:57

it's shaping up pretty well otherwise

Cora (she/her)05:04:15

I have some styling to do and a few more interactions to lock down

Cora (she/her)05:04:30

but it's getting really close

Cora (she/her)05:04:32

I also might move the downloading and indexing to a web worker and pass search data back and forth

lread13:04:23

That's great!