Clojurians Log v2
Clojure programming
Channels
Apps
clj-kondo 2025-12-29
I bumped clj-kondo to v2025.12.23, and for the first time in a while, it found a few things in rewrite-clj! 🎉🧵
An https://github.com/clj-commons/rewrite-clj/blob/6f49cd56c517cb9bc682923fbb0afa7e0caa03eb/src/rewrite_clj/node.cljc#L82 (:refer-clojure :exclude [string coerce])
👍 1
A good warning about unquote syntax not syntax-quoted https://github.com/clj-commons/rewrite-clj/blob/6f49cd56c517cb9bc682923fbb0afa7e0caa03eb/test/rewrite_clj/parser_test.cljc#L140-L144, (I think the warning is generally great, but will ignore it here).
👍 1
And finally, it found what I think might be a false positive https://github.com/clj-commons/rewrite-clj/blob/6f49cd56c517cb9bc682923fbb0afa7e0caa03eb/src/rewrite_clj/node/coercer.cljc#L139-L142. It found that string is an unresolved var. But I think, for cljs, in this context, it is valid: https://cljs.github.io/api/cljs.core/extend-type. Lemme know what you think.
borkdude 2025-12-29T19:21:42.105639Z
hmm, it surprises me that this is a new thing since the last release. let me test that
borkdude 2025-12-29T19:23:54.594389Z
$ clj -M:clj-kondo/dev --lint - --filename foo.cljc <<< "(defprotocol IDude) (extend-type #?(:cljs string :clj String) IDude)"
linting took 41ms, errors: 0, warnings: 0string is also the name of a namespace in your code... let me test that.borkdude 2025-12-29T19:25:42.811389Z
hmm, yeah that's it. something has changed around using namespaces as values in CLJS in clj-kondo which probably causes this. I'll make an issue.
$ clj -M:clj-kondo/dev --lint - --filename foo.cljs <<< "(ns foo (:require [clojure.string :as string])) (defprotocol IDude) (extend-type string IDude)"
foo.cljs:1:82: warning: Unresolved var: stringCool, thanks!