2025-05-20 clj-kondo | Clojure Slack Archive

clj-kondo 2025-05-20

escherize 2025-05-20T16:47:22.038779Z

I'd like to setup a kondo linter to dissallow System/exit. I wanted to add it as a discouraged var (or similar), but I think since it's a method that isn't going to work. Do I need to write a hook? I didn't see a built in one here: https://github.com/clj-kondo/clj-kondo/blob/master/doc/linters.md but I might have missed it.

borkdude 2025-05-31T10:51:40.585779Z

Here's a PR proposal: https://github.com/clj-kondo/clj-kondo/pull/2548

🎉 2

2025-05-20T16:48:36.676619Z

(relevant clj-kondo issue: https://github.com/clj-kondo/clj-kondo/issues/2234)

👍 2

dpsutton 2025-05-20T17:17:19.515869Z

this could be smart and use clj-kondo, but this could also be dumb and regex on System/exit

borkdude 2025-05-20T17:26:22.880089Z

this already works with :discouraged-var when you configure it with java.lang.System/exit

🎉 2

borkdude 2025-05-20T17:28:42.834719Z

(kind of by accident, but someone relied on it so I kept the behavior)

escherize 2025-05-20T19:36:56.718059Z

I am not seeing that:

$ clj-kondo --version
clj-kondo v2025.04.07
$ echo '(ns hmm) (System/exit 12)' > hmm.clj
$ clj-kondo --lint hmm.clj --config '{:linters {:discouraged-var {java.lang.System/exit {:message "uh o"}}}}'
linting took 3ms, errors: 0, warnings: 0

escherize 2025-05-20T19:37:08.771429Z

I might be holding it wrong

2025-05-20T19:37:35.846419Z

do you need to set the level?

escherize 2025-05-20T19:39:13.146959Z

Ohh, I'll try that

escherize 2025-05-20T19:40:38.565799Z

Hmm, guess not:

$ clj-kondo --version
clj-kondo v2025.04.07
$ echo '(ns hmm) (System/exit 12)' > hmm.clj
$ clj-kondo --lint hmm.clj --config '{:linters {:discouraged-var {java.lang.System/exit {:message "uh o" :level :error}}}}'
linting took 37ms, errors: 0, warnings: 0

escherize 2025-05-20T19:41:17.324789Z

Tried with warning too:

clj-kondo --lint hmm.clj --config '{:linters {:discouraged-var {java.lang.System/exit {:message "uh o" :level :warning}}}}'
linting took 4ms, errors: 0, warnings: 0

2025-05-20T19:45:26.046609Z

interesting

borkdude 2025-05-20T19:46:27.751289Z

sorry I was confused, it works for analyze-call, not for discouraged-var: https://github.com/clj-kondo/clj-kondo/issues/1603

👍 1

❤️ 1

borkdude 2025-05-20T19:46:58.439269Z

so you could write a hook for it today, or write a github issue

escherize 2025-05-20T20:07:28.724869Z

I wrote an issue here, I think I've captured it well, lmk if you'd like me to ammend it: https://github.com/clj-kondo/clj-kondo/issues/2541

borkdude 2025-05-20T20:16:41.809749Z

thanks!

Clojurians Log v2

clj-kondo 2025-05-20