clj-commons

lread 2021-01-25T20:48:14.003200Z

Heya @slipset! Are any clj-commons project using http://codecov.io yet? I use it for rewrite-cljc-playground and am interested in using it for clj-commons/rewrite-clj. There is no fee for open source projects.

slipset 2021-01-25T20:52:51.004Z

Don’t think it’s being used. Feel free.

👍 1
lread 2021-01-25T22:48:54.008500Z

I’m not sure what kind of privs I’d need you to set to allow me to enable codecov for clj-commons/rewrite-clj. I am going push a button to request you grant me access to clj-commons from for codecov from GitHub. If that looks like not a good idea, lemme know.

lread 2021-01-28T18:28:10.010500Z

I by no means want to pester you, but when you get a chance, would like to figure out if setting up codecov for a clj-commons project is a reasonable thing (I can’t do it without privs).

slipset 2021-01-28T18:30:16.010700Z

Hey, no stress, you’re not at all pestering.

borkdude 2021-01-25T20:53:53.004200Z

I found it annoying tbh

borkdude 2021-01-25T20:54:31.004700Z

at least the way it was set up with carve for a while: each PR was followed by a code coverage report on github, which felt a bit spammy

lread 2021-01-25T22:40:49.007800Z

Yeah @borkdude, I think I remember it failing builds if coverage thresholds changed or were not met, I configured it to stop doing that. Since I’ve been working solo on rewrite-cljc, I don’t know about PR spam. I’ll look into it.

lread 2021-01-25T22:42:58.008300Z

Yeah they can be disabled https://docs.codecov.io/docs/pull-request-comments via config.