@qerub has joined the channel
I got a PR the other day (https://github.com/clj-commons/camel-snake-kebab/pull/67) and noticed that Circle CI isn't triggered for PRs on this repo. I added the missing webhook (visible at https://github.com/clj-commons/camel-snake-kebab/settings/hooks). Anything I should be aware of? Should we make sure all repos have this integration?
Yeah. It's a CircleCI setting as well I think: build PRs or not
Has there been any discussion about Circle CI vs. GitHub Actions?
I guess it's down to personal preference. I personally prefer CircleCI in terms of features and stability, to be honest. Also, they are a Clojure shop, so from that perspective it makes sense to promote them a bit
I just recently switched rewrite-cljc over to GitHub Actions from CircleCI because I wanted to take advantage of their more generous 7gb of RAM for GraalVM native-image testing (CircleCI offers 3.5gb). GitHub Actions free tier also allows me to test against macOS, Windows and Linux.
That is true
I use appveyor for Windows, which to be honest, works great
If I would have no interaction with CircleCI / @marc-omorain who helped me get macOS access and more memory, I would've probably switched over already.
But I bet most Clojure projects don't need more RAM and are test on the JVM only
Yes, don’t get me wrong, I really like and appreciate CircleCI, it was just that GitHub Actions is a better fit for me for this particular project.
Re: https://github.com/clj-commons/camel-snake-kebab/issues/65, what do you people thing is the proper result of splitting the string "x" with the separator \x? I've accidently made the library behave different in CLJ vs CLJS.
@qerub, if you take inspiration from clojure.string/split, (str/split "x" #"x");; => []
note that I have no familiarity with the camel-snake-kebab library…
That's fine. Using clojure.string/split seems like a good way to get the same behaviour on CLJ and CLJS so I'll probably switch to that. Thanks.
"x".split("x") evaluates to an array with two empty strings in JS for the record.