Fork me on GitHub
#chlorine-clover
<
2021-07-21
>
fabrao12:07:01

one question, the result of chlorine should be the same as console repl ?

fabrao12:07:52

I have one situation here that I got differences from them

fabrao12:07:18

This is from chlorine

fabrao12:07:56

this is from console repl

mauricio.szabo14:07:07

You mean, from a REPL on a terminal, not the side-panel REPL inside Atom, right?

mauricio.szabo14:07:57

If so, no, it's not the same. On Chlorine, because of UNREPL, you can get "partial results". In your example, it's probably a bug that Chlorine is not parsing correctly the result of an exception...

fabrao15:07:39

oh, maybe yes

fabrao15:07:27

so, is that something that you will fix in future or is this something that will be in that way

mauricio.szabo15:07:39

I'll fix in the future. Really soon now, I just need a little bit more of a hammock time 😄

seancorfield15:07:22

@mauricio.szabo I feel I've asked this before but I'll ask that you refresh my poor old memory: is there a reason that Clover does not show results inline in the editor? I believe Calva does for nREPL/Orchard?

mauricio.szabo16:07:39

Right, so answering both you and Fabrao here: Originally, I wanted Chlorine to have a better EDN rendering. This meant making a map of EDN -> Reagent Component. But to iterate faster I made the decision to use UNREPL (I'm still not sure if that was the right path). Because of that, some "invalid EDN" but valid Clojure code were wrapped into records/types in ClojureScript (for example, IncompleteStr that's something really specific to UNREPL). So now, I have essentially "invalid EDN" wrapped over "ClojureScript objects" 😢, and lots of leaky abstractions and other ugly things. So what I'm doing right now is going back to basics so I can have a "valid EDN" again, to just pr-str it and send it to Clover. It's a work-in-progress, and its slowly happening. This "leaky abstractions" are also getting into the way of having more interesting customizations and evolving the code overall, but they are also old code so they have some style problems (currently, when I eval something on Chlorine/Clover, it somehow knows how it'll be rendered, and that's not right at all).

mauricio.szabo16:07:19

So, TL;DR; - because of old code that treats the result of a REPL as HTML, and VSCode only accepts strings in the API for inline results 😄

seancorfield17:07:26

Ah, OK, so the end goal is to get to a point where inline results will become viable again in Clover?

mauricio.szabo17:07:11

Yes, exactly.

2
💯 2