Clojurians Log v2

Assuming this channel: thoughts on https://github.com/slipset/deps-deploy/issues/62 ? In particular, the validation or renaming portion, since that caught someone out on Slack (per that ticket). Since I'm no longer using Erik's version and that issue has had no movement for over two and a half years, I was planning to close it, but I'm wondering if I should open a similar ticket against the Babashka version?

Given the Babashka version doesn't use Maven, I don't even know how it handles this when the JAR has an "unexpected" name...

At the risk of annoying you, can you give me an example of this use case?

I'm open to receiving issues

An example of the renaming/validation? It's in the Slack thread linked in the ticket (and in the preview above). For the multiple classifier thing, no, I don't have an example.

you would save me a lot of time if you could extract the right information from that thread, it takes me a lot of time to read it

Nah, I'll just close that ticket out. Probably no point in you spending any cycles on it, unless someone actually trips over either issue with your deps-deploy lib.

FWIW I fed this info to a clanker and it told me this problem doesn't even exist in bb.deps-deploy today. But take it with a grain of salt. Happy to help if it turns out to be a problem

I'm just doing my weekend routine of reviewing issues I've opened on various projects and seeing if any should be closed/moved to other projects 🙂

I did more digging. The problem doesn't exist in babashka/deps-deploy since the upload name is derived from the pom, not the local file name. A classifier is only taken from the file name when it has the form <artifact>-<version>-<classifier>.jar, so <artifact>-standalone-<version>.jar is uploaded as <artifact>-<version>.jar, as Maven's deploy plugin does. I added an extra check that one deploy can never contain multiple jars with the same upload name.

And it can't misinterpret <artifact>-standalone-<version>.jar as <artifact>-<version=standalone>.jar with a <classifier=version> because it checks those segments with regexes? What about <artifact>-<version>-<rc1>.jar (or alpha/beta/etc)

There is no regex on the version. it comes from the pom. A classifier is only taken when the file name starts with exactly <artifact>-<pom-version>-. So <artifact>-<version>-rc1.jar with pom version <version>-rc1 uploads as the main jar. The one case that can go wrong is this one: foo-1.0-rc1.jar with a pom that says 1.0: that is read as classifier rc1 Maybe an explicit classifier option would be better but this requires accepting separate option along with the filenames. Open to suggestions, if this is necessary.

Seems like a pretty obscure edge case though, although could happen in theory

Thank you!