I was trying to build the docker image from the master branch but it is failing for me

Execution error (FileNotFoundException) at babashka.impl.common/eval187$loading (common.clj:1).
Could not locate sci/ctx_store__init.class, sci/ctx_store.clj or sci/ctx_store.cljc on classpath. Please check that namespaces with dashes use underscores in the Clojure file name.

Full report at:
/tmp/clojure-1249190392639535167.edn
Error encountered performing task 'do' with profile(s): 'base,system,user,provided,dev,xml,yaml,csv,transit,httpkit-client,httpkit-server,core-match,hiccup,test-check,selmer,logging,priority-map,reflection'
Suppressed exit
The command '/bin/sh -c ./script/uberjar' returned a non-zero code: 1

I’ve tried with BABASHKA_LEAN=true as well, without much luck

$ docker build --build-arg BABASHKA_LEAN=true -t babashka:slim .

@UJSBQNUG6 did you clone the babashka repo with --recursive ? It has git submodules

yes, I’ve just realized this in this exact minute 😄

thank you

https://github.com/babashka/babashka/pull/1523

this was the Docker issue I was talking about earlier in another thread

@UJSBQNUG6 thanks for the change, just fyi this reduces the image of the docker image for local consumption and not the ones we push out to the registry. what exactly was the issue you were facing?

well, then I guess we need to modify

or I don’t know which one is pushed to the registry

but IIRC that had the same issue

yeah thats pretty lean anyways. we simply pack the binary in it. the one you changed is where its built

https://hub.docker.com/layers/babashka/babashka/latest/images/sha256-7138a298ab0d963190240ce87fa869236f6821d770208b79078ef95014702926?context=explore

this image has the same issue, it does an apt-get update without removing the package information later

if you check the 7th layer you can see that

ah yes, do you wanna update the PR then? its more useful in http://Dockerfile.ci actually

sure, I can

should I revert my changes in the Dockerfile?

can keep it, if someone is building off it locally

👍

would apk too have something similar? https://github.com/babashka/babashka/blob/master/Dockerfile.alpine

done

the Alpine image has --no-cache, so I believe that is good

although hadolint can see a couple of issues with the images

I can fix those issues if you want

I can see that the /tmp/glibc-2.28-r0.apk is not removed

sure go for it

also - in my opinion - if you are using multi staged builds it is not necessary to combine the RUN commands in the build image

since the size there does not really matter since you are not pushing that anywhere and it actually hurts the build time since if anything changes it cannot use the layer cache

what is the point to install tar in the Alpine image?

tar is necessary for bb pods

ok, and I guess the Ubuntu image has that already

yes

if you want the absolute most minimal image, you can start from scratch and just copy the linux static binary

without changing the bb images at the risk of breaking something

why is rm graalvm-ce-java19-linux-${GRAALVM_ARCH}-${GRAALVM_VERSION}.tar.gz removed?

because it is not necessary in the build image, as I wrote above

ok

> also - in my opinion - if you are using multi staged builds it is not necessary to combine the RUN commands in the build image you mean the Dockerfile right? agreed but i dont think we use circle's layer cache. is all ephemeral machines

yes, and by local builds

adding rm /tmp/glibc-2.28-r0.apk could further reduce the Alpine image by 2.3MB

I won’t do anymore modifications in this PR

we could address the hadolint issues in a separate PR maybe?

yes thats what i was gonna say

some of them are false positives

$ hadolint Dockerfile*
Dockerfile:4 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
Dockerfile:5 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
Dockerfile:5 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:70 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:71 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:73 DL3007 warning: Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag
Dockerfile:74 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:74 DL3015 info: Avoid additional packages by specifying `--no-install-recommends`
Dockerfile.alpine:9 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
Dockerfile.alpine:9 DL3019 info: Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
Dockerfile.alpine:16 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile.alpine:17 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile.alpine:18 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile.alpine:19 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile.alpine:24 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
Dockerfile.alpine:24 DL3019 info: Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
 DL3007 warning: Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag
 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
 DL3015 info: Avoid additional packages by specifying `--no-install-recommends

yeah these are too pedantic ones

the first too makes sense

lets do it all in a different PR, this one is in a good bounded context

looks fine to me, waiting for the ci run to finish

also could you add a changelog entry too? can make a unreleased section in https://github.com/babashka/babashka/blob/master/CHANGELOG.md

sure

done

now that i look at it why is WORKDIR "/usr/local/bin" needed?

all the paths are absolute there

that effectively changes the pwd of the bb CMD right?

WORKDIR will create the directory for us

true, I was not thinking about that

please don't make any changes that aren't necessary to the problem statement that goes with this PR

sure

yeah thats not needed

lets stick to mkdir, the other one is effectively a breaking change in some sense

true, I am sorry

no worries! good that we can catch these things early on 😄

ok, LGTM too, thanks @UJSBQNUG6!

i'll merge it?

I don't think the docker step is ran in branches right? so waiting for CI might not make sense

done

thank you guys for the super quick merge

you should not have to delete any caches when upgrading, but if you want to by pass the caches, you can pass bb -Sforce

if you can make a repro of this, if possible, that would be helpful

sure - i think i messed up my bb/clojure/java versions somehow, trying to get to the bottom of it now

what does bb --version say?

v1.3.176

❯ bb --version                                                                                                                                                                       7:10PM
egrep: warning: egrep is obsolescent; using grep -E
babashka v1.3.176

and clojure looks like:

~/russmatney
❯ bb clojure --version                                                                                                                                                               7:11PM
egrep: warning: egrep is obsolescent; using grep -E
Clojure CLI version (deps.clj) 1.11.1.1257

~/russmatney
❯ clojure --version                                                                                                                                                                  7:11PM
egrep: warning: egrep is obsolescent; using grep -E
Clojure CLI version 1.11.1.1224

i'm wondering if those versions should align

1224 vs 1257

no need to align

if you have deleted your .m2 or .gitlibs folder then it could be that you would get such an exception, but -Sforce should fix that

gotcha - i did delete .m2 at some point, but forgot .gitlibs

and you can ditch home .clojure/.cpcache + local-dir .cpcache as well, in doubt

bah, still the same error with all those cleared. must be something else that's wrong 😕

thanks for the help anyway - i'll dig around a bit

if you put the same deps from bb.edn in a deps.edn and start clj, does it work?

yeah - the deps install and i hit a repl

then moving things back and running bb again, same crash

and with bb -Sforce?

bb -Sforce hits the same error

bb -Sforce                                                                                                          7:22PM
egrep: warning: egrep is obsolescent; using grep -E
Error: Could not find or load main class clojure.main
Caused by: java.lang.ClassNotFoundException: clojure.main
Exception in thread "main" java.io.FileNotFoundException: /home/russ/.clojure/.cpcache/1621164B24C75150EF237DB929581D8A.cp (No such file or directory)
  

what is that egrep thing

testing in babashka/fs now to be sure it's not the repo

the egrep is noise, sorry

a zsh error i haven't gotten around to yet

what is in ~/.deps.clj ?

❯ ~/.deps.clj/                                                                                                        7:22PM
./            1.10.3.1040/  1.11.1.1149/  1.11.1.1165/  1.11.1.1200/  1.11.1.1237/
../           1.11.1.1113/  1.11.1.1155/  1.11.1.1182/  1.11.1.1208/  1.11.1.1257/

and in 1.11.1.1257?

❯ l ~/.deps.clj/1.11.1.1257/ClojureTools/                                                                             7:24PM
./                             clojure-tools-1.11.1.1257.jar  tools.edn
../                            example-deps.edn               tools.zip

just the ClojureTools dir

maybe throw away that dir, long shot

well hey!

i think that did it

instead bb -Sforce showed

Clojure tools not yet in expected location: /home/russ/.deps.clj/1.11.1.1257/ClojureTools/clojure-tools-1.11.1.1257.jar
Downloading  to /home/russ/.deps.clj/1.11.1.1257/ClojureTools/tools.zip
Unzipping /home/russ/.deps.clj/1.11.1.1257/ClojureTools/tools.zip ...
Successfully installed clojure tools!

maybe the download of the tools jar didn't work correctly the first time

and a repl

confirming it's working in the original repo! yay!

thanks so much @U04V15CAJ 😄

it's slightly devastating when bb fails on me b/c i lose all my key bindings and window-management powers, haha

but i still love it!

maybe I should add a sha256 check or so for that tools jar download

anyway, glad it's solved