This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # babashka (2)
- # babashka-sci-dev (15)
- # beginners (44)
- # clara (6)
- # clj-kondo (5)
- # clojure (39)
- # clojure-europe (5)
- # clojurescript (14)
- # data-science (5)
- # datahike (6)
- # datalevin (7)
- # graalvm (2)
- # helix (3)
- # humbleui (7)
- # minecraft (1)
- # missionary (10)
- # nbb (8)
- # nrepl (2)
- # portal (11)
- # shadow-cljs (3)
- # tools-deps (6)
- # xtdb (10)
@borkdude https://github.com/babashka/babashka/pull/1294 seems to work as expected and should be in a good state i think. But, we have required checks which are not generated on the shorted config, hence the merge status is red. Any suggestions on that?
And this is tested much better than last time https://app.circleci.com/pipelines/github/babashka/babashka?branch=pull%2F1294&filter=all 😛
Nice! > But, we have required checks which are not generated on the shorted config Hmm, maybe discuss that issue with the circleci folks, since he/they suggested that we use this dynamic config? Not a big deal probably, just a nice to have. About the refill: no idea, let's ignore :)
well we could generate stubbed configs for the required checks to keep GH happy. this seems to be a more github side issue than circle?
or would it be too bad to disable the required checks? we can make sure of it before merging?
@rahul080327 in the linux build, there is the
MACOSX_DEPLOYMENT_TARGET: 10.13 env var. It probably doesn't hurt, but just looks weird :)
yeah about the extra var, thought to leave it out to have lesser conditional workarounds in the code, that part looks more weird than the generated conf 😛
> I don't see the BABASHKA_STATIC env var will do a more thorough check along with this
ah yes, looks good now I think. I'll go over it one more time in the coming week, but I think you nailed it this time, thanks Agata and Rahul