Fork me on GitHub
#babashka-sci-dev
<
2022-06-19
>
lispyclouds18:06:07

@borkdude https://github.com/babashka/babashka/pull/1294 seems to work as expected and should be in a good state i think. But, we have required checks which are not generated on the shorted config, hence the merge status is red. Any suggestions on that?

lispyclouds18:06:44

Also decided to inline the check logic as most of the script is bb specific

lispyclouds18:06:10

also im seeing this, yet things seem to work fine

borkdude18:06:07

Nice! > But, we have required checks which are not generated on the shorted config Hmm, maybe discuss that issue with the circleci folks, since he/they suggested that we use this dynamic config? Not a big deal probably, just a nice to have. About the refill: no idea, let's ignore :)

lispyclouds18:06:33

well we could generate stubbed configs for the required checks to keep GH happy. this seems to be a more github side issue than circle?

lispyclouds18:06:00

or would it be too bad to disable the required checks? we can make sure of it before merging?

borkdude18:06:13

not sure, we can do that later I guess

borkdude18:06:30

@rahul080327 in the linux build, there is the MACOSX_DEPLOYMENT_TARGET: 10.13 env var. It probably doesn't hurt, but just looks weird :)

borkdude18:06:07

I don't see the BABASHKA_STATIC env var in the aarch64 static build

lispyclouds19:06:35

yeah about the extra var, thought to leave it out to have lesser conditional workarounds in the code, that part looks more weird than the generated conf 😛

lispyclouds19:06:23

> I don't see the BABASHKA_STATIC env var will do a more thorough check along with this

lispyclouds19:06:19

also maybe having this in the .circleci/script is better

borkdude19:06:16

ah yes, looks good now I think. I'll go over it one more time in the coming week, but I think you nailed it this time, thanks Agata and Rahul

lispyclouds20:06:20

we'll figure out a solution to the gh required status by tomorrow evening