very cool! just fyi, the "tree" is really a graph - if the same lib shows up at multiple points in the tree, do you get expansion on all of them, or is there some visual indication of omitted children? also, one thing that is often difficult to debug is exclusions - are those just missing or is there some way to tell a lib has a child that is being excluded? (extra difficult because it may be excluded due to parents multiple levels up)

Thanks! This is just a visualization of what clojure-lsp already has in it's analysis in memory, and all that analysis come from the classpath command that the user configure for that project (usually the default clj -Spath), so if the classpath command excludes that lib you won't see that there, would be difficult indeed to show those exclusions

so it's really just a flat list of libs?

(which is fine, I just misunderstood)

Yes, all libs available in the classpath

I think it's the same that other tools like Java for vscode does, I actually based on that

gotcha, then nvm!

Can Eglot user profit from this or is this lsp-mode only? Edit: It is a custom function, so I guess the answer is “can’t” 🙂.

only if eglot allow extends that, but ATM it's only available for lsp-mode as I coded manually that https://github.com/emacs-lsp/lsp-mode/blob/master/clients/lsp-clojure.el#L453-L561. That's something that I wish would go to LSP protocol itself, but that's another discussion :)

And what was the motivation for writing it? Or rather, what do you usually use it for?

@UBRV1HXPD that was a feature request from some users but the last one that asked made me realize it was something that other tools like cursive and other langs like Java had that we didn't had anything closer and that works out of the box to easily visualize the project scope

Most frequently it’s to check versions of transitives and I currently solve that with lein deps tree. It’s also just to see what’s present. Some things behave differently depending on what’s on the class path. Rarely it’s because I want to use a library in a pinch and I don’t know if it’s available; if it’s not then I make do without.

Thanks! I tried it and I like it very much. So I am trying to rewrite it for Eglot + hierarchies.el 🙂 .

Cool, thanks @UBRV1HXPD!

The work on the project-tree for Eglot is going well. But could someone please advise me what files inside the external dependency are visible in the context of the extracted JAR? The point is that I would like to offer the user a list of files that he can visit (via Jarchive), but I'm not quite clear what is reasonable selection to offer.

@UBRV1HXPD that's great! not sure I got, but we don't extract the jar, we just list the contents, and technically all of them are accessible by user

@UKFSJSM38 For some reason I can’t make rewrite-edn to be visible under my external dependencies but when i take a look into your picture I see it was expanded to 4 things. Can you help me to understand what these are and how did you get them?

btw. this is how it will look for the eglot.. but right now, clicking on jar just opens the dired with its content

looks nice! Yeah, the jars are expansible and they should show namespaces or java classes

You can see https://github.com/clojure-lsp/clojure-lsp/blob/161c9c80b09d1d209120d09b4cee5b160f433171/docs/capabilities.md#L168 they are type 5 or 6

basically if your node is not final, you should be able to request more children nodes

Thanks, type 4 itself does not provide any additional nodes. But if it’s just classes and namespaces, it shouldn’t be a problem to filter them out of the archive. Do you do that too? I’m trying to figure out the best way to get this list of them. Once I have it, it won’t be a problem to visit them via jar:file://....

I found a solution, everything is good 🙂

good! I'm not sure if there is anything clojure-lsp is doing wrong, but this comment should help understand along with the test: https://github.com/clojure-lsp/clojure-lsp/blob/a59f0c6e9d8340ecea53e6bdc6f0f2e977c85ae4/lib/src/clojure_lsp/feature/project_tree.clj#L138

Thanks, the tests are useful. So the “problem” is that when I call

(eglot--request (eglot-current-server) :clojure/workspace/projectTree/nodes '(:name "rewrite-edn-0.3.4.jar" :detail "jar:file:///Users/akiz/.m2/repository/borkdude/rewrite-edn/0.3.4/rewrite-edn-0.3.4.jar" :uri "jar:file:///Users/akiz/.m2/repository/borkdude/rewrite-edn/0.3.4/rewrite-edn-0.3.4.jar" :final :json-false :type 4))

(:name "rewrite-edn-0.3.4.jar" :type 4 :detail "jar:file:///Users/akiz/.m2/repository/borkdude/rewrite-edn/0.3.4/rewrite-edn-0.3.4.jar" :uri "jar:file:///Users/akiz/.m2/repository/borkdude/rewrite-edn/0.3.4/rewrite-edn-0.3.4.jar" :nodes [])

Hum, weird, we get https://github.com/clojure-lsp/clojure-lsp/blob/7ed3133845e1b0c103e890a1e7c7a1e689b4cdd3/lib/src/clojure_lsp/feature/project_tree.clj#L54-L55 the ns and java classes from that uri, the only thing I can think is that jar contain only .class files and not .java or .clj :thinking_face:

It contains .clj files. I used the same external dependency as you did in your picture. Just to be sure. Then i will investigate furher. Would be nice to avoid my current workaround which is 1. “use jar command to get content of the jar” 2. filter all clj files 3. create nodes based on them and add them as a children of the dep 4. clicking on them will open them via find-file and jarchive

yeah, clojure-lsp should provide that already, does that works for you with lsp-mode though?

It does and now it works with Eglot too! I also changed lsp’ setting to :dependency-scheme "jar" maybe it was it?

ah yeah, lsp-mode sets that by default, and I think the only client that don't set that is vim

And thanks again! I am glad that i can get rid of that workaround…

Cool, glad we have it working for eglot too!

And one more question @UKFSJSM38 - if I may - perhaps the last one - what do you use to decompile java class?

clojure-lsp uses https://www.benf.org/other/cfr/, https://github.com/clojure-lsp/clojure-lsp/blob/a77e910998277ede4badc5266b5e321da449c1c0/lib/src/clojure_lsp/feature/java_interop.clj#L26

🙏