Fork me on GitHub
#aleph
<
2023-08-03
>
Francesco Pischedda18:08:17

Hi there! I have posted a small blog post covering Aleph and I'd like to have your feedback šŸ™ https://clojurians.slack.com/archives/C8NUSGWG6/p1691087302126619

Matthew Davidson (kingmob)09:08:46

Hey, looks good! A few minor comments about Aleph/Manifold: > Manifold pre dates clojure.core.async Afaik core.async is older than Manifold, not the other way around. The first commit of core.async is 10 months older than the first commit of Manifold. > these data structure can be used as the body of a response and Aleph will return their contents as soon as they are available and will close the connect ion as soon as these sources will be closed True, Aleph will delay cleaning up necessary resources until the underlying deferred/stream for the body is done, but to be precise, the network connection isn't one of them (except in the rare case when keep-alive is false). For the most part, given the high overhead of creating connections, we try to keep them around and reuse them for multiple requests/responses. > ... see how it is used in Aleph's examples here. http://Aleph.io is a cool way to present docs, but it's getting out-of-date, and unfortunately, we no longer have access to it. The most up-to-date docs are at http://cljdoc.org, and the current examples are in the examples/ subdirectory in the repo. > (def _server (atom nil)) Slight stylistic note: I usually see underscores prefixing things that are meant to be ignored, like a param you don't need.

Francesco Pischedda10:08:05

Hi @U10EC98F5 šŸ™‚ Thanks for your feedback! > Afaik core.async is older than Manifold I've based my assumption on the copyright statement of both projects ā€¢ https://github.com/clj-commons/manifold#license: Copyright Ā© 2014-2022 Zach Tellman ā€¢ https://github.com/clojure/core.async#license: Copyright Ā© 2017-2023 Rich Hickey and contributors Could it be possible that the repo in clj-commons project has more recent initial commits than the original project? > the network connection isn't one of them Probably I have to make it clear that I am referring to the deferred or stream and not to the network to avoid confusion, thanks for pointing this out! > The most up-to-date docs are at http://cljdoc.org, Thanks again! I will adjust the link to point to cljdoc > Slight stylistic note: I usually see underscores prefixing things that are meant to be ignored, like a param you don't need. You are right! I always confuse the ignore case from the derefferable case, is it it common to use an underscore in a postfix position or something else?

Matthew Davidson (kingmob)10:08:21

I don't know where the 2017 core.async copyright year comes from; I based that on the initial git commit timestamp. But even assuming Hickey sat on it before announcing it, he gave a talk on core.async in 2013, as did Tim Baldridge.

Matthew Davidson (kingmob)10:08:00

> I always confuse the ignore case from the derefferable case Deref-able? I'm not familiar with any notation to indicate deref-ability. Have you checked the https://guide.clojure.style/#naming?

Matthew Davidson (kingmob)10:08:47

> Thanks again! I will adjust the link to point to cljdoc Unfortunately, the stuff in examples/ is NOT yet in http://cljdoc.org... šŸ˜”

Francesco Pischedda10:08:39

> he gave a talk on core.async in 2013, as did Tim Baldridge. mmm at this point I am inclined to remove that sentence, maybe pointing out that both came out almost at the same time > Have you checked the https://guide.clojure.style/#naming? I didn't find anything specific there, maybe it is my memory of the coding style of a previous job, I'll adjust it so that at least id does not conflict with the idiom of something to be ignored > Unfortunately, the stuff in examples/ is NOT yet in http://cljdoc.org... šŸ˜” I will add the examples in this case šŸ¤

Matthew Davidson (kingmob)11:08:40

> Could it be possible that the repo in clj-commons project has more recent initial commits than the original project? No, because the clj-commons repos are forks, not new repos, so the history is the same.

šŸ‘ 1