Hiii, why do I get a 204 No Content when I POST to try to create the phone number resource?

(defn post-phone [ctx]
  (phones/write-number-reported (:number (:parameters ctx)) (:country (:parameters ctx))))

(defn get-phone [ctx]
  (defn post-phone [ctx]
    (phones/read-number-reported (:number (:parameters ctx)))))

(defn server-routes []
  [""
   [
    ["/about" (yada/as-resource "Hello World")]
    ["/phone" :number (yada/resource
                       {:methods
                        {:get
                         {:parameters {:path {:number String}}
                          :produces   "application/json"
                          :response   get-phone}
                         :post {:parameters {:path {:number String}
                                             :body {:country String}}
                                :consumes   "application/json"
                                :produces   "application/json"
                                :response   post-phone}}})]]])

curl -X POST      -H 'cache-control: no-cache'   -H 'content-type: application/json'   -d '{"country":"us"}' -i

What is post-phone returning?

nil, it's a direct call to a dynamoDB fn.

ohhhhh

yeah 🙂

resources-are-data 🙏

Hrm... I have it return a {} and I'm still getting a 204

The debugger attached to the fn isn't executing, so I think my path is wrong?

are your routes correct there?

As far as I know, unless I have the format wrong...

I would have expected something more like [["/phone" :number] (yada/resource ...)]

ohhh

https://github.com/juxt/edge/blob/de6fcd354f76b3d447b39a3c70dc1ec7959a9ba4/src/edge/phonebook.clj#L132

Ahh. Thanks for the link! OK, I adjusted to that format, still getting a 204.

(defn server-routes []
  [""
   [
    ["/about" (yada/as-resource "Hello World")]
    ["/phone"
     [
      [["/" :number] (yada/resource
                       {:methods
                        {:get
                               {:parameters {:path {:number String}}
                                :produces   "application/json"
                                :response   get-phone}
                         :post {:parameters {:path {:number String}
                                             :body {:country String}}
                                :consumes   "application/json"
                                :produces   "application/json"
                                :response   post-phone}}})]]]]])

I do like the route/resource composibility though, that's neat

ah

I know

maybe

When you return {} Yada doesn't know if that is a resource, or a map

you should instead get the response out of the context, add the {} to that, and return it

(assoc-in ctx [:response :body] {})

See yada.methods:250 for what's happening

actually line 305

I found out my problem, not sure how to fix it though. Everything resolves fine if I don't have an encoded URL, like ... however, if there's an encoded char in the URL, that's when I get the 204, like

relevant resource:

(defn server-routes []
  [""
   [["/about" (yada/as-resource "Hello World")]
    ["/phone"
     [[["/" :number] (yada/resource
              {:parameters {:path {:number String}}
               :produces   ["application/json"]
               :methods
               {:get  {:response get-phone}
                :post {:parameters {:body {:country String}}
                       :consumes   "application/json"
                       :response   post-phone}}})]]]]])

(defn post-phone [ctx]
  {})

(defn get-phone [ctx]
  {})