This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-04-10
Channels
- # beginners (61)
- # boot (264)
- # cider (125)
- # cljs-dev (3)
- # clojure (118)
- # clojure-gamedev (3)
- # clojure-greece (1)
- # clojure-italy (1)
- # clojure-nl (2)
- # clojure-poland (3)
- # clojure-russia (38)
- # clojure-spain (2)
- # clojure-spec (17)
- # clojure-taiwan (1)
- # clojure-uk (42)
- # clojurescript (118)
- # clojutre (5)
- # cursive (24)
- # datomic (22)
- # emacs (3)
- # events (2)
- # figwheel (19)
- # funcool (1)
- # jobs-discuss (224)
- # jobs-rus (1)
- # klipse (14)
- # luminus (1)
- # lumo (49)
- # off-topic (51)
- # om (34)
- # pedestal (1)
- # perun (1)
- # planck (93)
- # powderkeg (1)
- # re-frame (15)
- # ring (4)
- # rum (9)
- # slack-help (3)
- # spacemacs (2)
- # specter (13)
- # uncomplicate (1)
- # unrepl (22)
- # untangled (10)
- # yada (36)
This can be handled through adding judicious logging interceptors into the right place in the chain
@malcolmsparks I’d like to pass the option to cheshire to escape non-ascii characters. I see there is another option pretty
that is activated like this: https://github.com/juxt/yada/blob/432d1b25f83a4af5d94d1108f37ee253a2a74bce/ext/swagger/src/yada/swagger.clj#L169
@malcolmsparks Would a PR that adds the non-ascii option to this make sense? Or is the pretty
parameter something HTTP specific?
@malcolmsparks think that has to be a record for my fastest PR merged 🙂
also factoring in the speed-of-light between NZ and MK 🙂
Pieter Hintjens had this philosophy of merging all PRs immediately, he would review them later, and make a reverting PR if he didn't like it.
Yeah it's an interesting philosophy, lots to like about it
I’m thinking of using that strategy in the liberator project because I hope for a smaller backlog. However, I think it wouldn’t save me any time because I had to review and fix stuff anyways. Still a very interesting idea, I think it would lower the barrier for new developers actually becoming involved into the project.
my daughter is 4, I'm going to give her yada merging rights (as soon as she gets her github id)
@malcolmsparks Any ideas about the “escape-non-ascii” parameter? https://clojurians.slack.com/archives/C0702A7SB/p1491812296094771
lots of thoughts, hard to type on a phone... :)
JSON mimetype is application/json. No parameters registered.
@malcolmsparks Didn’t know you were on a phone, it can wait 🙂
So pretty
is a poor hcck
@malcolmsparks I’m looking for a better solution than to override all the defmethods
@borkdude no problem :)
I'm curious about non-ascii chars. What is the driver for this? JSON is utf8 (or utf16/utf32 if you add a byteorder mark), but utf nonetheless
But you can use defmethod to override yada's default handling of application/json. I think Clojure's multimethods give yada an extensibility that is hard to achieve so easily and elegantly in other frameworks
For pretty
and other parameters of application/json we need a new media-type such as vnc.yada/json or alternatives
@malcolmsparks The driver is this: https://clojurians.slack.com/archives/C0702A7SB/p1491595709270085
Oh ok. I understand now. Thanks!
Do you think yada should escape by default?. This seems like something that should be the default
@malcolmsparks I’m not sure. Maybe we could make it more flexible by allowing :cheshire/escape-non-ascii
and :cheshire/pretty
keys on the resource
Hmm. Good idea. Like the namespaced keys idea. Perhaps yada.chesire to avoid ownership issues.
This opens up a lot of interesting possibilities with yada resource models