Hi, does bidi only accept keywords for matches?

I want the route to match to a var, which contains a function that renders the correct HTML

right now I'm working around it like this:

(def app-routes
  ["/" {"" :home-page
        "about" :about-page
        "dev" :dev-page
        "login" :login-page}])

(def route-match
  {:home-page  #'pages/home-page
   :about-page #'pages/about-page
   :dev-page   #'pages/dev-page
   :login-page #'login/login-page})

this looks really awkward

bidi accepts keywords, functions and (I believe) vars. I will check

let me just paste the error I get for clarity

Ok

bidi.cljc:183Uncaught Error: No protocol method Matched.resolve-handler defined for type cljs.core/Var: [object Object]

https://github.com/juxt/bidi/blob/master/src/bidi/bidi.cljc#L362

That's the problem

ah, is it meant to be unsupported?

Unlikely.

Probably just a case of whoever did the cljc didn't know about cljs.core/Var (or it didn't exist then? not sure!)

that's good news ^^

@jethroksy: It's probably best if you try and make the patch yourself, and test it on your own codebase by using lein install

I can provide a little helping hand if you need.

yeah I'll try to make a PR

That would be great!

There are some tests which do run on cljs, so maybe we need some tests which use vars there too.

I'll ping you for help when I need it 🙂

@dominicm: there seems to be no tests the different protocols for Matched

but the fix does work

Send the PR and I'll backfill the tests if necessary

https://github.com/juxt/bidi/blob/master/test/bidi/bidi_test.cljc#L10 this might be where to add it

Perhaps a fn at the top of this file which gets referred via #'var-test-handler or something.

i'll cook something up for the time being

PR sent

can I just check if I'm using bidi.ring/make-handler correctly?

(def app-routes
  ["/" {"" #'pages/home-page
        "about" #'pages/about-page
        "dev" #'pages/dev-page
        "login" #'login/login-page
        "register" #'registration/register-page}])

#?(:clj (def app-handler
          (->> app-routes
               (w/postwalk #(if (var? %) (layout/render-index %) %))
               make-handler)))

Then in another file I do:

(def app-routes
  (routes
   #'app-handler
   #'service-routes
   (route/not-found
    (:body
     (error-page {:status 404
                  :title "page not found"})))))

oops I was overcomplicating things

fixed it 🙂

Thanks for the PR.

no, thanks for bidi 🙂