yes, but I still need to migrate those endpoints from 1.0 to 1.1, so it's probably quite different (and doesn't use the multipart async upload)

@imre

@stijn ha, me too - 1.0 is solid and i haven't had the time yet

any public sample code I could look at?

I'm on 1.1 but don't need async

@imre: looking at my code now, i didn't use yada for the file-upload... i added a vanilla ring handler for that route and added the wrap-multipart-params middleware https://www.refheap.com/48f85c721c0c389d8e78835f6

not big, not async, and not very clever

thanks

I'm tempted to do it using yada though

yeah, i'll move to using yada for file-upload when i upgrade to 1.1

File uploads works but desperately needs docs. Juxt have a client hammering it with gatling tests. There's a glitch with the boyer moore multipart but otherwise it's solid

@mccraigmccraig the async upload part of yada is something I think will be very valuable, but it needs a bit of time to mature.

Wish I hadn't had to write so much code there, would have been nice to have netty devs implement more support

Hopefully that will happen. Ideally I could rewite in java and submit to netty but i'm not familiar with the committing process

I believe that for now yada is unique in this capability. Could ne wrong.

If I want to server css using bidi and yada, is [“/public” (yada (new java.io.File “path/to/public”))] the right way to go about it? As in, so that localhost:<port>/css/styles.css works?

It seems to be correct, looking at https://yada.juxt.pro/manual/010_intro.md, but I’m getting cannot treat nil as HTTP response for request to ‘’

If I write the route explicitly [“/public/css/styles.css" (yada (new java.io.File "path/to/public/styles.css"))], then the stylesheet is returned.

/public/

That error tells you bidi isn't matching anything

Make sure your / are all corre t

But yes, you're coding it right

thanks mate - I’ll check those slashes.

matching uris is a little too unforgiving

Sorry - sure I’m missing something really simple here: `(def routes ["" ["/public/" (yada (new java.io.File "resources/public/"))]])`. Shouldn’t that match /css/foo.css if the css folder is in resources/public?

I’m on [yada "1.1.0-20160225.101107-28”] and [bidi "2.0.0"]

Solved! ["" [["/" (yada (new java.io.File "resources/public/"))]]]

The route I was calling didn’t have the public path in it and so obviously didn’t match - makes perfect sense

@malcolmsparks: do you happen to have an example for a file upload resource definition?

you'll have to look in the tests

i've got some client deadlines today so I'll give you some pointers later tonight

@addywaddy: good to hear. I might create a #slashes slack channel to deal with bidi/yada puzzles that involve slashes...

but yes, once you understand it, it does makes sense

thanks, will go through the tests then

Ha! Thanks mate. All this talk about slashes is making me want to go to the loo … 😉

Looks like this works for the file upload: https://gist.github.com/imrekoszo/b99cf6a253ef0b82be32

I'm wondering what is the best to put as the schema for the file data though instead of Any: {:parameters {:form {:file schema.core/Any}}

for swagger ui to pick it up properly

I have some code from @frankie we could borrow that enables file uploads from a swagger ui. I need to check it.

That multipart bug I mentioned was a bug in another lib yada is using. So yada is ok, just need to hack up a boyer-moore implementation over the weekend. Small world, @mccraigmccraig already wrote one (in C I believe)

the swagger uploads, there is a simple implementation in ring-swagger. Intented for ring, but shows what needs to be generated to the spec.

https://github.com/metosin/ring-swagger/blob/master/src/ring/swagger/upload.clj

might not be that different in yada?