Fork me on GitHub
#xtdb
<
2020-05-21
>
jarohen15:05:40

@vaelatern, @dominicm - have merged Dominic's PR so that falsey args bind correctly, and also have https://github.com/juxt/crux/pull/888 raised to fix the issue where unused falsey args cause tuples not to be yielded. Will wait on an internal review for the latter, and then we should be good to go

thegeez20:05:04

This code doesn't look right to me, I think the timeout argument should be passed along to await-tx: https://github.com/juxt/crux/blob/master/crux-core/src/crux/node.clj#L152-L155

jarohen20:05:59

agreed 😳 would you be able to submit us a PR?

refset22:05:59

@U06D9RGQM yes, sorry this slipped through! Are you actively using the sync API still? Or were you just curious?

thegeez11:05:23

@U050V1N74 I can't make a PR as I can't print at moment and then sign the CLA, hence my drive-by post here

thegeez11:05:50

@U899JBRPF I'm not using the sync api, I was curious for something else in the code

👍 4
refset11:05:31

cool, good to know, thanks for flagging it up 🙂

jarohen11:05:40

@U06D9RGQM no problem, will pop the change through. thanks again 🙂