Fork me on GitHub
#vim
<
2022-06-03
>
sheluchin12:06:24

Thanks for the release @UEENNMX0T. I seem to be getting some errors after upgrading:

2022-06-04T08:45:35.537 INFO (pid:1056268) [plugin] - coc.nvim initialized with node: v12.18.0 after 127ms
2022-06-04T08:45:42.232 ERROR (pid:1056268) [extensions] - Error on createExtension coc-clojure from /home/alex/.config/coc/extensions/node_modules/coc-clojure/lib/index.js /home/alex/.config/coc/extensions/node_modules/coc-clojure/lib/index.js:5
...

SyntaxError: Unexpected token '?'
    at new Script (vm.js:88:7)
    at createScript (vm.js:263:10)
    at Object.runInContext (vm.js:294:10)
    at Module._compile (/home/alex/.nvim/plugged/coc.nvim/build/index.js:269:16088)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at Object.X0e.i.require (/home/alex/.nvim/plugged/coc.nvim/build/index.js:269:16589)
    at zV (/home/alex/.nvim/plugged/coc.nvim/build/index.js:269:17102)
Is there a strict requirement for node 14 or something?

Noah Bogart12:06:48

Yes but i can revert that. Coc.nvim 81 now requires node 14 but my plugin doesn't rely on anything from 14, i don’t think

sheluchin12:06:55

Hmm, it coc.nvim itself doesn't provide any warning/error and seems to be working otherwise:

node version: v12.18.0
coc.nvim version: 0.0.81-bacd91d7 2022-06-03 10:34:52 +0800

sheluchin13:06:54

BTW, do you welcome issues for the project or do you prefer a quick ping in here when some small issue comes up?

Noah Bogart13:06:10

If you need it fixed now, go to uh ~/.config/something/coc.nvim/extensions i think and change it in package.json and then run node rsbuild.js

Noah Bogart13:06:56

Issues last longer and i have a bad memory lol, but pinging me is good to problem solve

sheluchin13:06:55

> ~/.config/something/coc.nvim/extensions You mean to just roll it back to 0.0.6? and esbuild.js?

Noah Bogart13:06:16

I'm suggesting changing the minimum required version of node to 12 and rebuilding

Noah Bogart13:06:25

Should fix the issue for you

Noah Bogart13:06:30

You can also clone the repo, change it there, rebuild, and then add the repo to your vimrc

Noah Bogart13:06:35

Or wait like 5 hours for me to get back to my computer and fix it for you lol

sheluchin13:06:10

I just went ahead and upgraded node to 14 :man-shrugging: I think the autoinstall will cause problems for people like me who are using Linux Homebrew to install LSP. I tried setting the clojure.lsp-install-path to the brew install directory so it would detect it and leave it alone (my assumptions about how it works), but that didn't behave as I expected. I've scrapped my Homebrew version in favor of the autoinstall as it satisfies my needs right now. Perhaps the auto-install should include some configs to consider other installation methods. Not sure. Thanks for the help @UEENNMX0T.

👍 1
Noah Bogart14:06:14

Good to know! I’ll make a note in the readme. Glad you figured it out

dharrigan18:06:10

Yes, perhaps a switch to turn it off please. I had to go around and customise all my config to point to where clojure-lsp is downloaded

dharrigan18:06:19

Whilst I welcome being able to download it, I already have it installed as part of my installation. Also, some people may perfer the static binary rather than the dynamic binary.

1
Noah Bogart18:06:22

Turn which off @U11EL3P9U ? Automatically downloading clojure-lsp?

dharrigan18:06:42

statically linked vs. dynamically linked.

dharrigan18:06:32

so, perhaps for those "power" users who already have the static/dynamic version of clojure-lsp already downloaded, a switch to just not attempt to download it.

Noah Bogart18:06:44

Is it available on your PATH already? If so, the behavior shouldn't change. Sounds like i messed something up

dharrigan18:06:08

Additionally, I also have clojure-lsp cloned and I build it from time to time with unreleased code changes on it. So I set the executable path directly.

dharrigan18:06:24

Yes, it was (for a long time 🙂 ) in my path, but when I fired up vim with the updated coc-clojure on it, it repeatingly asked me to download it (after each no thank you), until I then read the package.json and src code to understand how to explicitly set the path, to then not have the prompt to download appear.

Noah Bogart18:06:23

Sorry about that, sounds like i broke it. My apologies, that sucks. Wanna open a GitHub issue mentioning this? I’ll try to fix it tonight

dharrigan18:06:26

no worries 🙂