Fork me on GitHub
#untangled
<
2016-09-30
>
gardnervickers13:09:03

@tony.kay Turns out it’s not untangled, thanks for walking through that with me. Turning :pathopt on in the reconciler allows me to recreate this in vanilla Om.next.

anmonteiro13:09:33

@gardnervickers happy to look at a minimal repro

gardnervickers13:09:33

If you’d like me to put it in a different form let me know

anmonteiro13:09:47

doesn’t look very minimal to me

gardnervickers13:09:40

Yea, I’ll strip it down further. The issue only presents when you have a union inside of a union, so there needs to be a few components.

tony.kay15:09:07

@gardnervickers Cool. Nested unions isn't something I've used yet. Thanks @anmonteiro for continuing to be such a valuable resource to the community!

ethangracer15:09:22

@gardnervickers @anmonteiro we have been using nested unions extensively and haven’t had any issues apart from making sure it’s all hooked up correctly. We’ve definitely seen the no queries for component path error a fair bit, not just with unions. We think it happens when we transact with a follow-on read intended to re-render a component that isn't on the screen when the transaction is called

ethangracer15:09:26

of course, it’s very possible there is still an issue with unions, just sharing what we’ve encountered

tony.kay15:09:13

Hm. That would make sense, and would be a different kind of bug...it should be safe to ask for a re-render of something that isn't on screen...it should be a harmless no-op

tony.kay15:09:31

sounds like it only happens when pathopt is on (which it is in Untangled)

gardnervickers15:09:56

The issue we’re seeing is specifically with om/full-query choking on the path. I’ve refined my repro quite a bit more, and am still working on getting it down to a minimal case. https://gist.github.com/gardnervickers/68ea600676f319d3467d9c3a849439ca The issue only appears when there’s an ident on the top level join.

gardnervickers15:09:56

Moving this to om channel though, thanks for the help everyone!

tony.kay16:09:27

let us know the outcome

mitchelkuijpers22:09:20

@tony.kay Could I pitch in with the untangled documentation sprint? I am currently very busy with shipping something… But I should have some time next week 🙂