Fork me on GitHub
#untangled
<
2016-08-22
>
jasonjckn20:08:51

is there anyone else that can approve this PR besides tony?

jasonjckn20:08:02

since he's busy

ethangracer22:08:44

@jasonjckn: all tests passing?

jasonjckn22:08:38

head has test failure

ethangracer22:08:49

@jasonjckn: any idea if it was yours?

ethangracer22:08:13

or do you mean develop

ethangracer22:08:22

wouldn’t at all be surprised, haven’t been in there for some time

jasonjckn22:08:33

develop HEAD

jasonjckn22:08:38

there's 1 failure

jasonjckn22:08:53

LOG: 'Testing untangled.client.impl.network-spec'
LOG: 'Testing untangled.client.protocol-support-spec'
LOG: 'Testing untangled.client.data-fetch-spec'
Chrome 52.0.2743 (Mac OS X 10.11.6) untangled.client.data-fetch-spec __Query-response-processing--loaded-callback-__G__22594 FAILED
	Fail (__Query-response-processing--loaded-callback-__G__22594) (Error:NaN:NaN)
	Expected nil
	Actual: #object[Error Error: Assert failed: (reconciler? reconciler)]

LOG: 'Testing untangled.client.core-spec'
WARN: ' [  0.634s] [om.next] merge-state!: component must implement Ident'
`

ethangracer23:08:37

@jasonjckn ok, it's been super busy for me today too but I can get this tomorrow

jasonjckn23:08:50

cool thanks!