Fork me on GitHub
#untangled
<
2016-06-02
>
tony.kay19:06:26

@therabidbanana: OK, pushed an updated to 0.4.11-SNAPSHOT that removes the need for many forced re-renders. It still does them on post-mutations.

tony.kay19:06:38

Had to do some refactoring to make the global network activity marker support continue to work. It does possibly require you to change uses of load-data. There is a new named parameter :reads [:x :y] that adds the given keys to Om follow-on reads for re-render

tony.kay19:06:01

gives you more fine-grained control over what to render

tony.kay19:06:31

post mutations on load-data still trigger a root re-render, but I can probably leverage the :reads extension to eliminate that as well.

tony.kay19:06:26

The need for :reads is a potentially BREAKING CHANGE for apps, since they cannot rely on a complete re-render after load.

therabidbanana19:06:38

Interesting - I'll give it a look.

tony.kay19:06:40

Another note to the channel in general: I've discovered an error in design around lazily-loaded. The cookbook recipe on this is wrong as well (though it works).

tony.kay19:06:14

As designed, it can cause Om to throw unexpected errors about missing queries

tony.kay19:06:35

So, if you use that, expect a breaking change in 0.4.11 (once I've fixed it 😉 )

ethangracer20:06:39

@tony.kay: did you ever find the bug we were running up against yesterday?

tony.kay20:06:16

we need to compare app state...I'm guessing they're not identical, and that the new merge function is to blame

tony.kay20:06:34

If you could do that, that would help

ethangracer20:06:59

I’ve got my head pretty deep in other issues right now, but I’ll get to it soon as I can

tony.kay20:06:18

I think I found the problem

tony.kay20:06:30

not sure why it does not throw, though...or perhaps Om is catching it

tony.kay20:06:05

(sweep-merge was doing the wrong thing when the left-side was not a map in recursion, but the right side was)

tony.kay23:06:13

ok, there was an off-by-one error in the new sweep algorithm. Pushed new snapshot to clojars