What is this :join? value for? https://github.com/untangled-web/untangled-server/blob/master/src%2Funtangled%2Fserver%2Fimpl%2Fcomponents%2Fweb_server.clj#L15

I don't see it in the http-kit docs. http://www.http-kit.org/server.html

@currentoor: might be a vestige from a different server...Jetty?

yeah looks like it

hey while you're here

That code might have gotten copied in from somewhere

im about to push up a PR

but i was thinking do you want to have a :server section in the config.edn?

like :datomic

like, put port in there?

or just have all the http-kit fields at the root like port

yeah

these fields `[:ip :port :thread :worker-name-prefix :queue-size :max-body :max-line]`

the whole thing is the "server" config

oh right ok at the root then

yeah

just like port

do you have any requirements on commits?

Right...anything that is not specific to the server might move to root

so, if supporting IP, perhaps that moves?

I would prefer a squashed single commit in the PR...easier to deal with in history

cool

Are you making the "defaults" for these a bit more aggressive?

or not even passing them if unset?

also, it might be nice to validate things and give decent error messages...even better: info logging messages when they are overridden so ppl can see them being set at startup

https://github.com/untangled-web/untangled-server/pull/5

I did not touch the defaults, but I'd be happy to set them at whatever you prefer.

I'm logging the options that ultimately get passed to http-kit. Is that sufficient?

Maybe it makes sense to set them at the same defaults as nginx?

hmm lein checkouts doesn’t appear to work for clojurescript projects, @ethangracer any suggestions here?

@currentoor: I’ve used lein checkouts in clojurescript a bunch, not sure what issue you’re running into. The way I’ve done it most recently is by making a new cookbook project, and then putting a checkouts/ directory in the same directory as the project file. Then I’ll set the untangled-client version in the project file to the latest snapshot, and run lein deps so there’s a copy of the snapshot in ~/.m2. The last step is to create a symbolic link in the directory to the directory with the untangled-client project file.

there does have to be a copy the snapshot that you want to checkout in your local .m2, even though leiningen won’t actually use it

lein jar
lein pom
lein localrepo install -p pom.xml target/project_name-version.jar project_name version

^^^ you can run this from the untangled-client repo to make and install the dependency directly from the source code if the latest snapshot isn’t on clojars

@currentoor: You also need to make sure that the checkout src dirs are in your src path for cljs builds. ie :source-paths [“checkouts/untangled-client/src” …]

@ethangracer, @mahinshaw: thanks, i’ll try these later today, also this was a little non-obvious to me, should we document this somewhere?

an contribution section in the wiki perhaps?

we could put something about publishing to a local repo for sure, can’t hurt

Yeah, I think that’s a good idea. @ethangracer Do you have a preference on the repo for generic docs, because this isn’t specific to one project

I am thinking just link to the untangled web repo

@currentoor: is there anything I described about checkouts you didn’t see in the leiningen tutorial doc? I know mark’s piece isn’t in the leiningen doc

@mahinshaw: maybe a docs folder in the untangled project?

we should probably check in with tony

We also need to note that when doing clj/server stuff that there checkout source needs to be in the (set-refresh-dirs …) else they will not reload.

the lein docs only told me to make the symlink (which worked for untangled-server) but not any of the other stuff you two mentioned

yeah, the lein docs don’t cover some caveats

and you can add any other stuff to the contribution docs as well, like squashed commits and link to issue(s)

@ethangracer: Tony is in a meeting. We can ping him about it in a bit.

you guys were plenty helpful but as a boot user i had no idea about any of this

yeah, it’s definitely finicky

ahh, boot. I like boot. has it been successful with untangled.

also i doubt most average lein users even know about this, but i could be wrong

@mahinshaw: oh yeah works like a charm

it would be sweet to have a tutorial on how to set up with boot

I need to do a simple app with that some time. I really liked using it for pet projects last year

for those users who prefer it

Maybe we can add some stuff to the cookbook about using boot

@ethangracer: do want me add a cookbook? we’ve built our app using boot and untangled already

using untangled-{web server datomic}

sounds like you know the most about it, that’d be great

cool

@currentoor: Did you try the boot checkouts task?

wrt publishing a local version i wrote this:

#!/bin/bash
set -e -u

# Created publish-local script that publish the repo to your ~/.m2/repository
# using your projects name and current version
# It assumes that you are:
# - in the same directory as the project.clj
# - the project name and version string are on the first line

project_name=$(head -n 1 project.clj | cut -d' ' -f2)
simple_project_name=$(echo $project_name | sed 's/.*\///')
version=$(head -n 1 project.clj | cut -d' ' -f3 | sed 's/"//g')

lein jar
lein pom
lein localrepo install -p pom.xml \
         target/${simple_project_name}-${version}.jar \
         ${project_name} ${version}

i’ve tended to use that script more often then checkouts, but (checkouts) still comes in handy that I want to write (or fix) a link-checkouts script

@mahinshaw: yeah i’ve checkedout that task (see what i did there 😄)

was it usable for your case?

i was about to use it but then we just added an example project within the lib so i just used that

@adambros: pretty nifty

@currentoor: I'm totally game for a CONTRIBUTING.md file in untangled (the top-level project that has the website in it)

I should probably write a bit of that, but if you wanted to make it, put in the checkouts stuff, and issue a PR it would motivate me

FYI: I'm on vacation next week. I will try to check in some, but I'm going to be mostly out of touch.