Fork me on GitHub
#untangled
<
2016-05-05
>
currentoor00:05:37

@ethangracer: what do you mean by "in checkouts"

ethangracer00:05:04

Leiningen checkouts. Allows you to develop a project and its dependencies simultaneously

ethangracer00:05:55

Yeah, it has been wonderful for untangled development. Can be a bit finicky at times, fair warning, but mostly works well

currentoor00:05:47

if you ever get the chance, new project perhaps, checkout boot

currentoor00:05:00

it's made complicated builds really easy

ethangracer00:05:56

I've been meaning to play around with it, looks interesting

currentoor00:05:31

boot-reload is not as snappy as lein figwheel though

currentoor00:05:48

but i actually understand all of our config stuff

ethangracer00:05:28

Haha that might be a hard sell, I love the hot code reload... when it works at least 😬

currentoor00:05:36

oh boot has the same hot code reload features (i couldn't live without them) it's just slightly slower than figwheel

therabidbanana16:05:23

We appear to be encountering https://github.com/http-kit/http-kit/issues/196 in our production build (I suspect mainly due to a large amount of cookies).

therabidbanana16:05:31

It's a simple config change to HTTP-kit to work around - should I submit a patch to make it so the untangled server can configure both port and max-line, or just provide a custom server component when we initialize the untangled system?

therabidbanana16:05:33

(If going the fixing upstream route - any thoughts making all options of httpkit accessible vs just max-line? Maybe a config option to pass through server options?)

mahinshaw17:05:37

I think making the built in server more configurable would be great! We also need to add hooks to swap the server component as a whole. Those to me should be two separate PR’s, and would be welcome

tony.kay17:05:53

@therabidbanana: I'd prefer those become part of the config file (e.g. we only support port so far), then inject the config into the web server component (aready done) and look for the additional parameters

tony.kay17:05:23

I believe the web-server component is already pluggable (you can override) via calls in the component library...but for this problem I'd prefer we just expand the http-kit options via the config file. Something like: { :http-kit { :max-line n } }

mahinshaw17:05:35

right, the built-in :server just get’s overridden, when you add a custom one to :components

therabidbanana23:05:28

Sorry, forgot to do anything with this - I think @currentoor is going to look at the issue @tony.kay https://github.com/untangled-web/untangled-server/issues/4