hmm.. a clean clone of untangled-todomvc seems broken.

A sanity hint for incoming uncaught error:
 return or__26549__auto__;
} else {
return dkey;
}
})();
var by_ident_QMARK_ = om.util.ident_QMARK_ <<< ☢ NULL ☢ <<< .call(null,key);
om_plumbing.cljs:27 Uncaught TypeError: Cannot read property 'call' of undefined

Seems likely related to a sequence of WARNING: Use of undeclared Var om.util/ident? etc. on cljs compile.

@curtosis There was a change made to the latest untangled-client "0.4.7-SNAPSHOT" that is causing this error. We are currently working on a fix.

gotcha. I tried rolling to om alpha32, which fixed the ident? etc warnings, but not the error. Glad it's not just me, though!

Right. In the latest alpha32 ident? moved to om.util.

oops, I'm wrong - alpha32 fixes the error, too, once one remembers Chrome caches aggressively...

cool.

my bad....didn't realized todomvc was on 31...I'll push a fix t oGH

pushed

@curtosis: Thanks for the note...fix pushed to github

@tony.kay: pretty sure i fixed mark-missing for recursive queries on 0.4.7-SNAPSHOT

@currentoor: That auto-reload on todomvc....it reloads, but the reloads are not taking effect for me. Are you using that in dev anywhere where it is working for you?

the make-system is closed over in the user namespace, which means you're getting an old version of the system...so changes are not reflected, I think

yeah, refresh dirs must include user.clj in dev for it to work, but that breaks refresh...this is what I ran into last time I tried to implement it

@tony.kay: just read the UI query security recipe, magnificent! Some very solid ideas. Do you internally implement this like for example a json web token which translates to the user in the env of the server parser?

right, we have a server component injected into the parser called authorizer, which itself injects the handler and install a pre-hook in the ring pipeline to pull out cookies and turn that into a user. All that gets injected into the parsing environment

so, you can pull the authorizer straight from the env, run it on the query/user, and move on

sorry, two things injected

authorizer and openid

the openid component does the user bit

the authorizer has the logic that checks the query

so you don't use the openid component directly in parsing...just the authorizer. But the user stuff is placed on the request, which is also made visible in the parsing env

Now that you've asked that...I want to beef up the README

and the server code with a mock component or two to show those bits

😄

Awesome approach, hadn't given it a thought

@tony.kay: I'll investigate this weekend. Unfortunately I'm using the system library in my project.

@currentoor: ok, thanks. I think the solution is to move the dev helper functions themselves into untangled-server, so that the atom for holding the system (and watcher) are in the library. The user namespace will need to refresh, and re-initialize yet another atom that holds the "system constructor" function.

tools namespace blows away namespaces...defonce won't fix it

sounds like a good approach, thanks!

@tony.kay: we’re not talking about start-figwheel, just the server helpers start stop etc?

?

talking about the watcher code that was added to trigger auto-hot-reload on server code

you mentioned the atom holding the system

isnt that used by start & co.

yes

okay well anyway, id like to see it reload my code successfully

sounds nice

the watcher code needs to not be in hot reload, but system stuff does

so, another approach is to just add another source dir that is not in refresh dirs

just for the watcher

So, that works....I just did it as an alt source folder in todomvc

I don't want the watch deps in ut-server, so this is probably the fix

might be able to move refresh funcs into server, and ask users to set the constructor function in a reloaded user ns

@currentoor: ^^^

cool, so you got it working?

i'd like to see what you did

yeah, it'll be in the todomvc release I'm doing in a bit

awesome

Untangled spec 0.3.6 pushed to github and clojars

now has readme, which makes it at least look like the something that it is on github

Untangled client 0.4.7 (requires om alpha32) released

nice! I just narrowed down a nasty parse problem to something wrong in the client SNAPSHOT version.

frustratingly difficult to track down, but pleased it's not me going crazy.

(fwiw, I kept seeing No reader function for tag object in my file that :required data-fetch, but with no clues as to where. File null, line null, column null. Nothing to do but comment everything, then gradually uncomment line by line and build.)

anyway, excellent news on the new releases!

@curtosis: Sometimes, esp on project file changes, it pays to clean the project and restart everything...clears up things like that sometimes

also can be useful to do a command-line build...e.g. lein cljsbuild once dev

or auto....the auto will keep re-trying on file changes...which is much faster than restarting REPL

lein cljsbuild auto dev

Untangled Tutorial updated to new versions

Untangled Server 0.4.7 pushed

released to clojars

Argh.

Tempid rewrite looks broken on 0.4.7...not sure if it is a glitch in build, or a regression

@ethangracer: are you seeing tempid rewrite working ok with 0.4.7?

definitely not aware of that

@adambros: did your mark-sweep fix possibly touch rewrite logic?

not sure rewrite logic is?

tempid rewrites

it might be possible

should i come over?

yes

tempids are comign back from server still, so definitely a problem on client

tempids are rewriting on survey… ?

hm

Confirmed. 0.4.7 client breaks tempid rewrite

0.4.8 pushed with fix

on clojars...bumping stuff on other libs

ok, Todomvc, tutorial, and cookbook updated

So, consider 0.4.7 a bad release. Use 0.4.6 or 8

thanks for the quick fix!

untangled.client.mutations/toggle! works well for me in may main app but it fails in the devcards.

The calling component has an ident [dashboard/by-id 123].

and when i call (mut/toggle! this :ui/show-edit-menu?)

it replaces :dashboard/by-id {123 {...}} with :dashboard/by-id {nil {:ui/show-edit-menu? false}}

any suggestions?

hmm, i'm inspecting the props being passed in, when i call toggle! the component is re-render (as it should be) but all props except :ui/show-edit-menu? vanish

but this does not happen outside of a devcard

toggle! is called inside ui-dashboard