Fork me on GitHub
#unrepl
<
2017-11-30
>
cgrand10:11:00

@pesterhazy kv elisions are properly rendered (at the end and only one elision), plus ansi codes can be used (yay, syntax color)

cgrand10:11:08

And @dominicm’s colleagues fav:

pesterhazy11:11:11

this looks fantastic

cgrand14:11:09

I’m pretty impartial but yeah I think packed-parser does an awesome job 😉

pesterhazy11:11:41

is packed up in your branch already?

pesterhazy11:11:01

Re: mvn dependencies, we don't use any yet

pesterhazy11:11:58

Eventually I'd like to see if an AOT'd version of unravel would be better - that would solve the problem of shipping dependencies (and wouldn't require lumo as a production dep anymore, though we can still use it in dev)

cgrand11:11:11

Not yet pushed

pesterhazy11:11:19

probably easiest to inline the dependency for now (i.e. add src/)?

cgrand11:11:21

I thought about a git module too

cgrand11:11:33

But I found another way.

cgrand14:11:24

In next Lumo one can use clojurescript modules from npm. Packed is already there. So I added nodes_modules/packed/src to lumo classpath

pesterhazy14:11:14

distributing a cljs library via npm. interesting concept

cgrand14:11:49

and when next lumo is released and unravel is upgraded to it there will be no need to manually extend the classpath

pesterhazy11:11:53

I hate submodules with a passion

dominicm11:11:59

subtrees are your saviour

volrath11:11:26

I've never used subtrees although I hear they are great.. but I've never had problems with submodules either, so they're my go-to way for repo-to-repo dependency management

pesterhazy12:11:26

@dominicm can you elaborate?

dominicm12:11:56

@pesterhazy subtrees mitigate a lot of the pain points of submodules. The https://www.atlassian.com/blog/git/alternatives-to-git-submodule-git-subtree atlassian article is good

pesterhazy12:11:26

is it included in the standard git distro?

pesterhazy12:11:56

i'll give this a read thanks

dominicm12:11:11

I wish I could tell slack to not send the image, and only the text for links

pesterhazy12:11:54

we can probably disable expansions somewhere

volrath12:11:57

I think it's a setting

pesterhazy12:11:02

or an admin can

volrath12:11:13

I believe I've seen it in preferences

volrath12:11:21

preferences > messages > scroll down

dominicm12:11:32

is that a personal thing? I don't want to inflict pain on others 😄

dominicm12:11:55

That looks good anyways 🙂 Thanks.

dominicm12:11:03

Sorry, didn't mean to start an OT thing like that.

volrath12:11:19

haha can't say for sure, but I don't think you'll be able to modify somethingglobally without admin perms

cgrand14:11:24
replied to a thread:yeah?

In next Lumo one can use clojurescript modules from npm. Packed is already there. So I added nodes_modules/packed/src to lumo classpath

cgrand14:11:57

you need to use the flag packed

cgrand14:11:09
replied to a thread:this looks fantastic

I’m pretty impartial but yeah I think packed-parser does an awesome job 😉

cgrand14:11:49

@pesterhazy now that elisions stands out (because of ansi rendering), could it be possible to just print a number. Also commands could be /thing.

cgrand14:11:12

So if the user sees an underlined 12, the user know s?he has to type /12

cgrand14:11:49

and /thing is not readable which is a good thing

cgrand14:11:14

maybe even render as /12 so that the output is not readable

cgrand16:11:26

@pesterhazy if I use feature flags, do you prefer that I develop on a branch or on master?

pesterhazy21:11:49

I'd say on a branch - I do the same, makes for easier reviewing