Fork me on GitHub
#unrepl
<
2017-10-18
>
cgrand12:10:57

Ok I’ve got an interesting comment from someone trying unravel: long strings are not shortened

cgrand13:10:37

I believe it’s a valid point and I’m certainly going to add #unrepl/string [prefix #unrepl/... {:get (business as usual)}] to the format. Anyone has a counterpoint?

pesterhazy13:10:13

I think that's an excelent idea

dominicm13:10:50

Can't see anything immediately wrong

cgrand13:10:52

what should be a reasonable length before elision? 80?

dominicm13:10:04

I'm going to jump in and suggest we're very precise about this also: do we work on glyphs, byte lengths, etc.?

pesterhazy13:10:07

80 sounds about right to me

cgrand13:10:08

why? why do we need to be precise? precision -> coupling -> brittleness

pesterhazy13:10:31

I'm guessing we can make it configurable at some point (though not necessarily initially)

dominicm13:10:46

@cgrand because there's been a number of bugs in things I've used around cutting off a character half-way through and then not renconvening that.

dominicm13:10:15

fun fact, the auto-complete I wrote for nrepl was originally broken because the bencode library I used was doing # of bytes rather than number of characters.

cgrand13:10:26

@pesterhazy it would be controlled by a dynvar like depth & breadth elisions

pesterhazy13:10:52

.substring should do the right thing though, @dominicm?

cgrand13:10:56

@dominicm would “I hereby promise to not cut a surrogate pair” be enough?

cgrand13:10:15

@pesterhazy substring don’t care about surrogates

dominicm13:10:22

@cgrand Probably. I think it's good to be ahead of this kind of thing is all, because string cutting seems fraught with peril historically.

dominicm13:10:12

yeah, I think "not cutting surrogate pairs" covers the cases I can think of.

cgrand13:10:38

Thanks @dominicm you made a very valid point! I kept saying people how I’ve been lucky to early attract a core of people interested in unrepl, challenging, questioning, criticizing the protocol.

cgrand13:10:06

Any plan of coming to Berlin on Nov. 8th?

dominicm14:10:46

Hmm, that's fairly close, and my girlfriend does want to see Berlin :thinking_face:

dominicm14:10:21

ah, but it'll be term time. So I doubt I could bring her. So I guess not. Unfortunate.