Fork me on GitHub
#unrepl
<
2017-05-17
>
cfleming02:05:17

@cgrand @pesterhazy I had problems concatenating files to send over REPLs with servers running old Clojure versions. I can’t remember if 1.5.0 or 1.6.0 fixed a bug where you couldn’t have multiple ns forms in a single file.

cgrand07:05:06

cfleming: with nrepl load-file I assume, right?

cfleming08:05:32

@cgrand Yes, but it was a Clojure bug

cfleming02:05:43

Obviously unrepl is 1.5.0+ anyway because of EDN.

pesterhazy06:05:15

@cfleming, I would argue 1.8.0+ because of Socket Server

pesterhazy06:05:56

I was happy to find that concatenating the two files just worked for unravel

pesterhazy06:05:41

but eventually it might be easier/more manageable to put things into a single namespace

pesterhazy06:05:52

something to consider at least

cgrand08:05:03

Yeah I understand it was a Clojure bug. My point is just that when you have just a plain repl (socket or not) you don't trigger this bug.

cfleming08:05:09

I think you do - it was a problem in load-file IIRC

cfleming08:05:35

I can’t find the JIRA right now.

cgrand08:05:19

@cfleming with a plain repl there’s no load-file involved (you can’t assume a shared FS), you just feed it form by form (well char by char even).

cfleming09:05:28

@cgrand Tools will often use load-file behind the scenes though, e.g. by creating a temporary file to do so. It’s the only way to get file/line info for loaded forms (for debugging/stack traces)

cgrand09:05:56

we were talking about sending concatenated files, in this case file/line info is already so-so