tools-deps

namenu 2024-01-07T08:42:32.596819Z

In 1.11.1.1435, it doesn't work correctly when passing the :project argument in tools.deps/create-basis. (there was no problem in 1.11.1.1420) My guess is that this is a regression introduced in TDEPS-256. slurp-deps seems to try to read the file 'a/a/deps.edn'. (rather than 'a/deps.edn').

namenu 2024-01-07T08:44:15.989189Z

oh, passing the absolute path is one workaround

Alex Miller (Clojure team) 2024-01-07T14:19:07.845539Z

Can you share the repro for what you’re doing?

seancorfield 2024-01-07T17:57:18.083289Z

According to Jira, TDEPS-256 was fixed in 1.11.1.1420 so that was the release the behavior changed in, not 1.11.1.1435 (does that sound right @alexmiller?)

Alex Miller (Clojure team) 2024-01-07T17:59:59.838789Z

yes, but I'm confused by the original post which gives CLI version numbers but talks about tools.deps apis, so would like to know what is actually being done

πŸ‘πŸ» 1
Alex Miller (Clojure team) 2024-01-07T18:02:23.652509Z

https://github.com/clojure/tools.deps/blob/master/CHANGELOG.md is the tools.deps changelog, this changed in tools.deps 0.18.1370

Alex Miller (Clojure team) 2024-01-07T18:03:59.062099Z

the official https://clojure.org/releases/tools#_releases is really a combination of tools.deps and CLI and sometimes tools.deps.cli or tools.tools changes

Alex Miller (Clojure team) 2024-01-07T18:04:55.242579Z

all of the latter depend on tools.deps, but sometimes at a lag

Alex Miller (Clojure team) 2024-01-07T18:14:13.599629Z

I think I can repro, not sure why the tests I wrote for this are passing though, but I'll track it down

namenu 2024-01-08T00:19:49.410589Z

Thanks! The reason I mentioned the CLI version is because the real impact comes from using -X:deps. In testcase, adeps and bdeps are converted to absolute. Relativizing adeps might break the test. I will share my repro soon. πŸ™‚

Alex Miller (Clojure team) 2024-01-08T02:33:29.911029Z

I’ve fixed it, will do a release later this week

πŸ‘ 1
πŸ‘πŸ» 1
Alex Miller (Clojure team) 2024-01-08T02:33:41.705309Z

It was relative vs absolute

namenu 2024-01-08T03:02:28.565809Z

This is the first time I've seen anaphoric in use. eye-opening technique!

Alex Miller (Clojure team) 2024-01-08T03:25:09.784879Z

well, not sure it will stay :)