Fork me on GitHub
#tools-deps
<
2024-01-07
>
namenu08:01:32

In 1.11.1.1435, it doesn't work correctly when passing the :project argument in tools.deps/create-basis. (there was no problem in 1.11.1.1420) My guess is that this is a regression introduced in TDEPS-256. slurp-deps seems to try to read the file 'a/a/deps.edn'. (rather than 'a/deps.edn').

namenu08:01:15

oh, passing the absolute path is one workaround

Alex Miller (Clojure team)14:01:07

Can you share the repro for what you’re doing?

seancorfield17:01:18

According to Jira, TDEPS-256 was fixed in 1.11.1.1420 so that was the release the behavior changed in, not 1.11.1.1435 (does that sound right @U064X3EF3?)

Alex Miller (Clojure team)17:01:59

yes, but I'm confused by the original post which gives CLI version numbers but talks about tools.deps apis, so would like to know what is actually being done

1
Alex Miller (Clojure team)18:01:23

https://github.com/clojure/tools.deps/blob/master/CHANGELOG.md is the tools.deps changelog, this changed in tools.deps 0.18.1370

Alex Miller (Clojure team)18:01:59

the official https://clojure.org/releases/tools#_releases is really a combination of tools.deps and CLI and sometimes tools.deps.cli or tools.tools changes

Alex Miller (Clojure team)18:01:55

all of the latter depend on tools.deps, but sometimes at a lag

Alex Miller (Clojure team)18:01:13

I think I can repro, not sure why the tests I wrote for this are passing though, but I'll track it down

namenu00:01:49

Thanks! The reason I mentioned the CLI version is because the real impact comes from using -X:deps. In testcase, adeps and bdeps are converted to absolute. Relativizing adeps might break the test. I will share my repro soon. 🙂

Alex Miller (Clojure team)02:01:29

I’ve fixed it, will do a release later this week

1
👍 1
Alex Miller (Clojure team)02:01:41

It was relative vs absolute

namenu03:01:28

This is the first time I've seen anaphoric in use. eye-opening technique!

Alex Miller (Clojure team)03:01:09

well, not sure it will stay :)