Fork me on GitHub
#tools-deps
<
2019-10-01
>
plexus00:10:43

If there are gitlab users here that would be interested in using the private Maven repositories provided by gitlab, then please check out this patch and provide feedback. https://clojure.atlassian.net/browse/TDEPS-140

plexus00:10:03

Gitlab uses a token in a http header for authentication instead of the normal username/password method, this patch adds support for that.

mattyulrich04:10:16

is it possible to resolve a pom type dep (rather than a jar) in my deps.edn file?

mattyulrich04:10:01

I think in lein, one could specify :type "pom" and it would resolve the pom alone without requiring a jar at the end...

mattyulrich04:10:56

oh.. nevermind - I just found the :extension "pom" attribute - did the trick perfectly!

kirill.salykin12:10:25

Hi I am playing with Github actions and tools.deps, seems there is an issue with installing deps from private github repositories Did anyone also experienced it? Do I need to install my ssh key?

alexmiller12:10:11

Yes, you would need to do that

alexmiller12:10:45

I believe there is a special env var for it automatically in the action

alexmiller12:10:10

But you’d need to add it to the ssh-agent

alexmiller12:10:34

I haven’t done this yet myself so don’t have a recipe for you

kirill.salykin12:10:49

thanks, will try to install ssh key and add it to agent

kirill.salykin12:10:00

adding ssh key didnt help much

name: CI

on: [push]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/[email protected]
    - name: Install Clojure
      run: curl -O  && chmod +x linux-install-1.10.1.469.sh && sudo ./linux-install-1.10.1.469.sh
    - name: Setup ssh
      env:
        KEY: ${{ secrets.KEY }}
      run: mkdir -p ~/.ssh && echo "$KEY" > ~/.ssh/id_rsa && chmod 600 ~/.ssh/id_rsa && eval $(ssh-agent -s) && ssh-add -k ~/.ssh/id_rsa && ssh-keygen -F  || ssh-keyscan  >>~/.ssh/known_hosts
    - name: Run tests
      run: ./bin/run-tests-ci.sh

kirill.salykin12:10:19

Error building classpath. connector is not available: 
com.jcraft.jsch.agentproxy.AgentProxyException: connector is not available: 
	at com.jcraft.jsch.agentproxy.ConnectorFactory.createConnector(ConnectorFactory.java:120)

kirill.salykin12:10:31

please advice what can be wrong?

ghadi14:10:39

@kirill.salykin in Github Actions, do processes persist between steps?

kirill.salykin14:10:46

I don’t know, to be honest testing now

kirill.salykin14:10:24

yes, you are correct

kirill.salykin14:10:37

run: eval $(ssh-agent -s) && ssh-add -k ~/.ssh/id_rsa && ./bin/run-tests-ci.sh
this works

kirill.salykin15:10:45

> My guess is eval $(ssh-agent -s) dies at the end of that step? this is my guess as well

ghadi14:10:03

You can find out by running - run: ssh-add -l in a subsequent step

ghadi14:10:23

I have github actions building private git deps, but I'm doing it all within a container

kirill.salykin14:10:35

i am able to clone that repo via just git

ghadi14:10:06

but tools.deps isn't using git

kirill.salykin14:10:52

yeah, just to ensure that I can clone it

ghadi15:10:05

My guess is eval $(ssh-agent -s) dies at the end of that step? @kirill.salykin

ghadi15:10:23

oh just saw the thread

ghadi15:10:10

you should probably pin the http://github.com host key statically in source code

ghadi15:10:24

otherwise it will accept any known host key -- MITM attack