Fork me on GitHub
#tools-deps
<
2019-07-28
>
borkdude16:07:49

local/root is only used for development on a local machine? e.g. you cannot specify a local/root dep in a git dep? example: project/examples/deps.edn <- used as git dep, refers to library on level up as :local/root ".." project/deps.edn <- library

Alex Miller (Clojure team)17:07:37

With the most recent set of dir related fixes, I think that should work

borkdude18:07:40

I did try it, let me see if I have the latest

borkdude18:07:20

upgraded and I can confirm this works. this is awesome, thanks

borkdude18:07:53

what's cool is that it now works in dev but also as a git dep, without having to change anything in deps.edn: https://github.com/borkdude/clj-kondo/blob/dump-analysis/tools/deps.edn

dominicm18:07:47

there was another set of changes...?

borkdude18:07:39

it seems so 🙂

borkdude18:07:17

the version I'm using right now is 1.10.1.466

dominicm18:07:33

Nothing in the changelog indicates tdeps-132 is resolved. I think this is still an issue.

dominicm18:07:25

Essentially if you have 2 git dependencies in that repo, that both have a :local/root on C, then you'll hit an error: https://clojure.atlassian.net/browse/TDEPS-123 This is important for people who want to use Edge without cloning it.

borkdude18:07:49

:local/root on C?

dominicm18:07:37

given deps, A, B, C:

deps.edn
- A {:git/url ...}
  - C {:local/root "../C"}
- B {:git/url ...}
  - C {:local/root "../C"}

carkh21:07:53

hum cannot access this link if logged in service desk

carkh21:07:08

works when logged out though

carkh21:07:20

(not a deps issue)